Re: [PATCH] build: correct cppcheck-misra make rule

2022-09-09 Thread Bertrand Marquis
Hi Jan, > On 9 Sep 2022, at 15:26, Jan Beulich wrote: > > On 09.09.2022 15:50, Bertrand Marquis wrote: >>> On 9 Sep 2022, at 14:41, Jan Beulich wrote: >>> >>> It has been bothering me for a while that I made a bad suggestion during >> >> This is not a sentence for a commit message. > > How e

Re: [PATCH] build: correct cppcheck-misra make rule

2022-09-09 Thread Jan Beulich
On 09.09.2022 15:50, Bertrand Marquis wrote: >> On 9 Sep 2022, at 14:41, Jan Beulich wrote: >> >> It has been bothering me for a while that I made a bad suggestion during > > This is not a sentence for a commit message. How else should I express the motivation for the change? >> review: Having

Re: [PATCH] build: correct cppcheck-misra make rule

2022-09-09 Thread Anthony PERARD
On Fri, Sep 09, 2022 at 01:50:38PM +, Bertrand Marquis wrote: > > On 9 Sep 2022, at 14:41, Jan Beulich wrote: > > --- a/xen/Makefile > > +++ b/xen/Makefile > > @@ -746,11 +746,9 @@ cppcheck-version: > > # documentation file. Also generate a json file with the right arguments for > > # cppcheck

Re: [PATCH] build: correct cppcheck-misra make rule

2022-09-09 Thread Bertrand Marquis
Hi Jan, > On 9 Sep 2022, at 14:41, Jan Beulich wrote: > > It has been bothering me for a while that I made a bad suggestion during This is not a sentence for a commit message. > review: Having cppcheck-misra.json depend on cppcheck-misra.txt does not > properly address the multiple targets pro

[PATCH] build: correct cppcheck-misra make rule

2022-09-09 Thread Jan Beulich
It has been bothering me for a while that I made a bad suggestion during review: Having cppcheck-misra.json depend on cppcheck-misra.txt does not properly address the multiple targets problem. If cppcheck-misra.json is deleted from the build tree but cppcheck-misra.txt is still there, nothing will