Re: [PATCH] credit2: make sure we pick a runnable unit from the runq if there is one

2021-06-21 Thread Dario Faggioli
Hi George (and sorry for the delay in replying), On Mon, 2021-06-07 at 12:10 +, George Dunlap wrote: > > On May 28, 2021, at 4:12 PM, Dario Faggioli > > wrote: > > Reported-by: Michał Leszczyński > > Reported-by: Dion Kant > > Signed-off-by: Dario Faggioli > > Thanks for tracking this dow

Re: [PATCH] credit2: make sure we pick a runnable unit from the runq if there is one

2021-06-07 Thread George Dunlap
> On May 28, 2021, at 4:12 PM, Dario Faggioli wrote: > > A !runnable unit (temporarily) present in the runq may cause us to > stop scanning the runq itself too early. Of course, we don't run any > non-runnable vCPUs, but we end the scan and we fallback to picking > the idle unit. In other word,

[PATCH] credit2: make sure we pick a runnable unit from the runq if there is one

2021-05-28 Thread Dario Faggioli
A !runnable unit (temporarily) present in the runq may cause us to stop scanning the runq itself too early. Of course, we don't run any non-runnable vCPUs, but we end the scan and we fallback to picking the idle unit. In other word, this prevent us to find there and pick the actual unit that we're