Re: [PATCH] docs/misra: Add instructions for cppcheck

2022-06-29 Thread Luca Fancellu
> On 29 Jun 2022, at 11:16, Julien Grall wrote: > > Hi Luca, > > On 28/06/2022 16:23, Luca Fancellu wrote: >>> On 24 Jun 2022, at 18:25, Julien Grall wrote: >>> On 24/06/2022 14:34, Luca Fancellu wrote: > On 24 Jun 2022, at 13:17, Julien Grall wrote: >> Sorry for the late reply, this wo

Re: [PATCH] docs/misra: Add instructions for cppcheck

2022-06-29 Thread Julien Grall
Hi Luca, On 28/06/2022 16:23, Luca Fancellu wrote: On 24 Jun 2022, at 18:25, Julien Grall wrote: On 24/06/2022 14:34, Luca Fancellu wrote: On 24 Jun 2022, at 13:17, Julien Grall wrote: Sorry for the late reply, this would be my changes, would you agree on them? They LGTM. Cheers, -- Juli

Re: [PATCH] docs/misra: Add instructions for cppcheck

2022-06-28 Thread Luca Fancellu
> On 24 Jun 2022, at 18:25, Julien Grall wrote: > > Hi Luca, > > On 24/06/2022 14:34, Luca Fancellu wrote: >>> On 24 Jun 2022, at 13:17, Julien Grall wrote: >> I would keep the section about compiling cppcheck since many recent distro >> doesn’t provide cppcheck >=2.7 yet (and 2.8 is broken)

Re: [PATCH] docs/misra: Add instructions for cppcheck

2022-06-24 Thread Julien Grall
Hi Luca, On 24/06/2022 14:34, Luca Fancellu wrote: On 24 Jun 2022, at 13:17, Julien Grall wrote: I would keep the section about compiling cppcheck since many recent distro doesn’t provide cppcheck >=2.7 yet (and 2.8 is broken), If you agree with it. It depends on the content of the section.

Re: [PATCH] docs/misra: Add instructions for cppcheck

2022-06-24 Thread Luca Fancellu
> On 24 Jun 2022, at 13:17, Julien Grall wrote: > > > > On 24/06/2022 13:01, Luca Fancellu wrote: >> Hi Julien, > > Hi Luca, > +First recommendation is to use exactly the same version in this page and provide +the same option to the build system, so that every Xen developer

Re: [PATCH] docs/misra: Add instructions for cppcheck

2022-06-24 Thread Bertrand Marquis
Hi, > On 24 Jun 2022, at 13:22, Julien Grall wrote: > > On 24/06/2022 13:18, Bertrand Marquis wrote: >> Hi Julien, > > Hi Bertrand, > >>> On 24 Jun 2022, at 13:08, Julien Grall wrote: >>> >>> >>> >>> On 24/06/2022 12:40, Bertrand Marquis wrote: Hi Julien, >>> >>> Hi Bertrand, >>> >>

Re: [PATCH] docs/misra: Add instructions for cppcheck

2022-06-24 Thread Julien Grall
On 24/06/2022 13:18, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 24 Jun 2022, at 13:08, Julien Grall wrote: On 24/06/2022 12:40, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 24 Jun 2022, at 12:20, Julien Grall wrote: Hi Luca, On 24/06/2022 11:53, Luca Fancellu wrote

Re: [PATCH] docs/misra: Add instructions for cppcheck

2022-06-24 Thread Bertrand Marquis
Hi Julien, > On 24 Jun 2022, at 13:08, Julien Grall wrote: > > > > On 24/06/2022 12:40, Bertrand Marquis wrote: >> Hi Julien, > > Hi Bertrand, > >>> On 24 Jun 2022, at 12:20, Julien Grall wrote: >>> >>> Hi Luca, >>> >>> On 24/06/2022 11:53, Luca Fancellu wrote: Add instructions on ho

Re: [PATCH] docs/misra: Add instructions for cppcheck

2022-06-24 Thread Julien Grall
On 24/06/2022 13:01, Luca Fancellu wrote: Hi Julien, Hi Luca, +First recommendation is to use exactly the same version in this page and provide +the same option to the build system, so that every Xen developer can reproduce +the same findings. I am not sure I agree. I think it is good

Re: [PATCH] docs/misra: Add instructions for cppcheck

2022-06-24 Thread Julien Grall
On 24/06/2022 12:40, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 24 Jun 2022, at 12:20, Julien Grall wrote: Hi Luca, On 24/06/2022 11:53, Luca Fancellu wrote: Add instructions on how to build cppcheck, the version currently used and an example to use the cppcheck integration t

Re: [PATCH] docs/misra: Add instructions for cppcheck

2022-06-24 Thread Luca Fancellu
Hi Julien, >> +First recommendation is to use exactly the same version in this page and >> provide >> +the same option to the build system, so that every Xen developer can >> reproduce >> +the same findings. > > I am not sure I agree. I think it is good that each developper use their own > ver

Re: [PATCH] docs/misra: Add instructions for cppcheck

2022-06-24 Thread Bertrand Marquis
Hi Julien, > On 24 Jun 2022, at 12:20, Julien Grall wrote: > > Hi Luca, > > On 24/06/2022 11:53, Luca Fancellu wrote: >> Add instructions on how to build cppcheck, the version currently used >> and an example to use the cppcheck integration to run the analysis on >> the Xen codebase >> Signed-o

Re: [PATCH] docs/misra: Add instructions for cppcheck

2022-06-24 Thread Julien Grall
Hi Luca, On 24/06/2022 11:53, Luca Fancellu wrote: Add instructions on how to build cppcheck, the version currently used and an example to use the cppcheck integration to run the analysis on the Xen codebase Signed-off-by: Luca Fancellu --- docs/misra/cppcheck.txt | 66 ++

[PATCH] docs/misra: Add instructions for cppcheck

2022-06-24 Thread Luca Fancellu
Add instructions on how to build cppcheck, the version currently used and an example to use the cppcheck integration to run the analysis on the Xen codebase Signed-off-by: Luca Fancellu --- docs/misra/cppcheck.txt | 66 + 1 file changed, 66 insertions(+)