Re: [PATCH] libs/light: pass some infos to qemu

2021-01-27 Thread Manuel Bouyer
On Wed, Jan 27, 2021 at 10:06:43AM +0100, Roger Pau Monné wrote: > On Tue, Jan 26, 2021 at 11:42:23PM +0100, Manuel Bouyer wrote: > > On Mon, Jan 18, 2021 at 09:36:42AM +0100, Roger Pau Monné wrote: > > > [...] > > > > > > Note also that there are networking modes that don't use a bridge, so > > >

Re: [PATCH] libs/light: pass some infos to qemu

2021-01-27 Thread Roger Pau Monné
On Tue, Jan 26, 2021 at 11:42:23PM +0100, Manuel Bouyer wrote: > On Mon, Jan 18, 2021 at 09:36:42AM +0100, Roger Pau Monné wrote: > > [...] > > > > Note also that there are networking modes that don't use a bridge, so > > you could likely end up with nics[i].bridge == NULL? > > I couldn't cause t

Re: [PATCH] libs/light: pass some infos to qemu

2021-01-26 Thread Manuel Bouyer
On Mon, Jan 18, 2021 at 09:36:42AM +0100, Roger Pau Monné wrote: > [...] > > Note also that there are networking modes that don't use a bridge, so > you could likely end up with nics[i].bridge == NULL? I couldn't cause this to happen. If no bridge is specified in the domU's config file, qemu-ifup

Re: [PATCH] libs/light: pass some infos to qemu

2021-01-18 Thread Manuel Bouyer
On Mon, Jan 18, 2021 at 10:07:22AM +0100, Roger Pau Monné wrote: > On Mon, Jan 18, 2021 at 09:52:14AM +0100, Manuel Bouyer wrote: > > On Mon, Jan 18, 2021 at 09:36:42AM +0100, Roger Pau Monné wrote: > > > I also wonder why NetBSD needs to add the tap interface to the bridge > > > in the QEMU script

Re: [PATCH] libs/light: pass some infos to qemu

2021-01-18 Thread Roger Pau Monné
On Mon, Jan 18, 2021 at 09:52:14AM +0100, Manuel Bouyer wrote: > On Mon, Jan 18, 2021 at 09:36:42AM +0100, Roger Pau Monné wrote: > > I also wonder why NetBSD needs to add the tap interface to the bridge > > in the QEMU script instead of doing it from the hotplug script called > > by libxl, like Li

Re: [PATCH] libs/light: pass some infos to qemu

2021-01-18 Thread Manuel Bouyer
On Mon, Jan 18, 2021 at 09:36:42AM +0100, Roger Pau Monné wrote: > On Sat, Jan 16, 2021 at 12:25:02PM +0100, Manuel Bouyer wrote: > > On Sat, Jan 16, 2021 at 11:16:06AM +0100, Roger Pau Monné wrote: > > > On Tue, Jan 12, 2021 at 07:12:37PM +0100, Manuel Bouyer wrote: > > > > From: Manuel Bouyer >

Re: [PATCH] libs/light: pass some infos to qemu

2021-01-18 Thread Roger Pau Monné
On Sat, Jan 16, 2021 at 12:25:02PM +0100, Manuel Bouyer wrote: > On Sat, Jan 16, 2021 at 11:16:06AM +0100, Roger Pau Monné wrote: > > On Tue, Jan 12, 2021 at 07:12:37PM +0100, Manuel Bouyer wrote: > > > From: Manuel Bouyer > > > > > > Pass bridge name to qemu as command line option > > > When sta

Re: [PATCH] libs/light: pass some infos to qemu

2021-01-16 Thread Manuel Bouyer
On Sat, Jan 16, 2021 at 11:16:06AM +0100, Roger Pau Monné wrote: > On Tue, Jan 12, 2021 at 07:12:37PM +0100, Manuel Bouyer wrote: > > From: Manuel Bouyer > > > > Pass bridge name to qemu as command line option > > When starting qemu, set an environnement variable XEN_DOMAIN_ID, > > to be used by

Re: [PATCH] libs/light: pass some infos to qemu

2021-01-16 Thread Roger Pau Monné
On Tue, Jan 12, 2021 at 07:12:37PM +0100, Manuel Bouyer wrote: > From: Manuel Bouyer > > Pass bridge name to qemu as command line option > When starting qemu, set an environnement variable XEN_DOMAIN_ID, > to be used by qemu helper scripts > > Signed-off-by: Manuel Bouyer > --- > tools/libs/li

[PATCH] libs/light: pass some infos to qemu

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer Pass bridge name to qemu as command line option When starting qemu, set an environnement variable XEN_DOMAIN_ID, to be used by qemu helper scripts Signed-off-by: Manuel Bouyer --- tools/libs/light/libxl_dm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/li