Re: [PATCH] libxc: avoid clobbering errno in xc_domain_pod_target()

2021-12-09 Thread Jan Beulich
On 09.12.2021 11:41, Juergen Gross wrote: > On 09.12.21 11:36, Juergen Gross wrote: >> On 09.12.21 11:26, Jan Beulich wrote: >>> do_memory_op() supplies return value and has errno set the usual way. >>> Don't overwrite errno with 1 (aka EPERM on at least Linux). >>> >>> Signed-off-by: Jan Beulich

Re: [PATCH] libxc: avoid clobbering errno in xc_domain_pod_target()

2021-12-09 Thread Juergen Gross
On 09.12.21 11:36, Juergen Gross wrote: On 09.12.21 11:26, Jan Beulich wrote: do_memory_op() supplies return value and has errno set the usual way. Don't overwrite errno with 1 (aka EPERM on at least Linux). Signed-off-by: Jan Beulich --- An alternative would be to let go of the DPRINTK() and

Re: [PATCH] libxc: avoid clobbering errno in xc_domain_pod_target()

2021-12-09 Thread Juergen Gross
On 09.12.21 11:26, Jan Beulich wrote: do_memory_op() supplies return value and has errno set the usual way. Don't overwrite errno with 1 (aka EPERM on at least Linux). Signed-off-by: Jan Beulich --- An alternative would be to let go of the DPRINTK() and leave errno and err alone altogether.

[PATCH] libxc: avoid clobbering errno in xc_domain_pod_target()

2021-12-09 Thread Jan Beulich
do_memory_op() supplies return value and has errno set the usual way. Don't overwrite errno with 1 (aka EPERM on at least Linux). Signed-off-by: Jan Beulich --- An alternative would be to let go of the DPRINTK() and leave errno and err alone altogether. While the hypervisor side of the hypercall