Re: [PATCH] net/xen-netback: Break build if netback slots > max_skbs + 1

2023-10-05 Thread David Kahurani
On Thu, Oct 5, 2023 at 7:03 PM Jakub Kicinski wrote: > > On Thu, 5 Oct 2023 18:39:51 +0300 David Kahurani wrote: > > > MAX_SKB_FRAGS can now be set via Kconfig, this allows us to create > > > larger super-packets. Can XEN_NETBK_LEGACY_SLOTS_MAX be made relative > > > to MAX_SKB_FRAGS, or does the

Re: [PATCH] net/xen-netback: Break build if netback slots > max_skbs + 1

2023-10-05 Thread Jakub Kicinski
On Thu, 5 Oct 2023 18:39:51 +0300 David Kahurani wrote: > > MAX_SKB_FRAGS can now be set via Kconfig, this allows us to create > > larger super-packets. Can XEN_NETBK_LEGACY_SLOTS_MAX be made relative > > to MAX_SKB_FRAGS, or does the number have to match between guest and > > host? > > Historic

Re: [PATCH] net/xen-netback: Break build if netback slots > max_skbs + 1

2023-10-05 Thread David Kahurani
This change was suggested by Juergen and looked okay and straightforward to me. On Wed, Oct 4, 2023 at 9:48 PM Jakub Kicinski wrote: > > On Wed, 27 Sep 2023 11:29:18 +0300 David Kahurani wrote: > > If XEN_NETBK_LEGACY_SLOTS_MAX and MAX_SKB_FRAGS have a difference of > > more than 1, with MAX_SKB_

Re: [PATCH] net/xen-netback: Break build if netback slots > max_skbs + 1

2023-10-04 Thread Jakub Kicinski
On Wed, 27 Sep 2023 11:29:18 +0300 David Kahurani wrote: > If XEN_NETBK_LEGACY_SLOTS_MAX and MAX_SKB_FRAGS have a difference of > more than 1, with MAX_SKB_FRAGS being the lesser value, it opens up a > path for null-dereference. It was also noted that some distributions > were modifying upstream be

Re: [PATCH] net/xen-netback: Break build if netback slots > max_skbs + 1

2023-09-27 Thread Paul Durrant
On 27/09/2023 09:29, David Kahurani wrote: If XEN_NETBK_LEGACY_SLOTS_MAX and MAX_SKB_FRAGS have a difference of more than 1, with MAX_SKB_FRAGS being the lesser value, it opens up a path for null-dereference. It was also noted that some distributions were modifying upstream behaviour in that dire

[PATCH] net/xen-netback: Break build if netback slots > max_skbs + 1

2023-09-27 Thread David Kahurani
If XEN_NETBK_LEGACY_SLOTS_MAX and MAX_SKB_FRAGS have a difference of more than 1, with MAX_SKB_FRAGS being the lesser value, it opens up a path for null-dereference. It was also noted that some distributions were modifying upstream behaviour in that direction which necessitates this patch. Signed-