Re: [PATCH] tools/ocaml: Add missing vmtrace_buf_kb field

2024-02-14 Thread Christian Lindig
> On 14 Feb 2024, at 11:45, Andrew Cooper wrote: > > Xapi is the only consumer of this interface. I've fixed up the build > against staging, but we're not going to be running KFX under Xapi any > time soon. > > Ultimately it's Christian's call. After a discussion with Andrew, we will not

Re: [PATCH] tools/ocaml: Add missing vmtrace_buf_kb field

2024-02-14 Thread Andrew Cooper
On 14/02/2024 7:11 am, Jan Beulich wrote: > On 08.02.2024 10:13, Christian Lindig wrote: >>> On 7 Feb 2024, at 22:04, Petr Beneš wrote: >>> Add the missing `vmtrace_buf_kb` field to the OCaml bindings to match the >>> vm.cfg configuration, correcting an oversight from its initial introduction.

Re: [PATCH] tools/ocaml: Add missing vmtrace_buf_kb field

2024-02-14 Thread Petr Beneš
On Wed, Feb 14, 2024 at 8:12 AM Jan Beulich wrote: > > On 08.02.2024 10:13, Christian Lindig wrote: > >> On 7 Feb 2024, at 22:04, Petr Beneš wrote: > >> Add the missing `vmtrace_buf_kb` field to the OCaml bindings to match the > >> vm.cfg configuration, correcting an oversight from its initial

Re: [PATCH] tools/ocaml: Add missing vmtrace_buf_kb field

2024-02-13 Thread Jan Beulich
On 08.02.2024 10:13, Christian Lindig wrote: >> On 7 Feb 2024, at 22:04, Petr Beneš wrote: >> Add the missing `vmtrace_buf_kb` field to the OCaml bindings to match the >> vm.cfg configuration, correcting an oversight from its initial introduction. >> >> Signed-off-by: Petr Beneš > > Acked-by:

Re: [PATCH] tools/ocaml: Add missing vmtrace_buf_kb field

2024-02-08 Thread Petr Beneš
> On Thu, Feb 8, 2024 at 10:14 AM Christian Lindig > wrote: > > > On 7 Feb 2024, at 22:04, Petr Beneš wrote: > > > > > > Add the missing `vmtrace_buf_kb` field to the OCaml bindings to match the > > vm.cfg configuration, correcting an oversight from its initial introduction. > > > >

Re: [PATCH] tools/ocaml: Add missing vmtrace_buf_kb field

2024-02-08 Thread Christian Lindig
> On 7 Feb 2024, at 22:04, Petr Beneš wrote: > > > Add the missing `vmtrace_buf_kb` field to the OCaml bindings to match the > vm.cfg configuration, correcting an oversight from its initial introduction. > > Signed-off-by: Petr Beneš Acked-by: Christian Lindig This looks correct from an

[PATCH] tools/ocaml: Add missing vmtrace_buf_kb field

2024-02-07 Thread Petr Beneš
From: Petr Beneš Add the missing `vmtrace_buf_kb` field to the OCaml bindings to match the vm.cfg configuration, correcting an oversight from its initial introduction. Signed-off-by: Petr Beneš --- tools/ocaml/libs/xc/xenctrl.ml | 1 + tools/ocaml/libs/xc/xenctrl.mli | 1 +