Re: [PATCH] vpci/msix: restore PBA access length and alignment restrictions

2023-03-29 Thread Jan Beulich
On 29.03.2023 16:20, Roger Pau Monné wrote: > On Wed, Mar 29, 2023 at 03:22:34PM +0200, Jan Beulich wrote: >> On 29.03.2023 12:18, Roger Pau Monne wrote: >>> @@ -419,9 +424,8 @@ static int adjacent_write(const struct domain *d, const >>> struct vpci_msix *msix, >>> * assumed to be equal or b

Re: [PATCH] vpci/msix: restore PBA access length and alignment restrictions

2023-03-29 Thread Roger Pau Monné
On Wed, Mar 29, 2023 at 03:22:34PM +0200, Jan Beulich wrote: > On 29.03.2023 12:18, Roger Pau Monne wrote: > > @@ -419,9 +424,8 @@ static int adjacent_write(const struct domain *d, const > > struct vpci_msix *msix, > > * assumed to be equal or bigger (8 bytes) than the length of any > > acc

Re: [PATCH] vpci/msix: restore PBA access length and alignment restrictions

2023-03-29 Thread Jan Beulich
On 29.03.2023 12:18, Roger Pau Monne wrote: > @@ -419,9 +424,8 @@ static int adjacent_write(const struct domain *d, const > struct vpci_msix *msix, > * assumed to be equal or bigger (8 bytes) than the length of any access > * handled here. > */ > -if ( (VMSIX_ADDR_IN_RANGE(ad

Re: [PATCH] vpci/msix: restore PBA access length and alignment restrictions

2023-03-29 Thread Jan Beulich
On 29.03.2023 12:18, Roger Pau Monne wrote: > Accesses to the PBA array have the same length and alignment > limitations as accesses to the MSI-X table: > > "For all accesses to MSI-X Table and MSI-X PBA fields, software must > use aligned full DWORD or aligned full QWORD transactions; otherwise,

[PATCH] vpci/msix: restore PBA access length and alignment restrictions

2023-03-29 Thread Roger Pau Monne
Accesses to the PBA array have the same length and alignment limitations as accesses to the MSI-X table: "For all accesses to MSI-X Table and MSI-X PBA fields, software must use aligned full DWORD or aligned full QWORD transactions; otherwise, the result is undefined." Introduce such length and a