Re: [PATCH] x86/HVM: refine when to send mapcache invalidation request to qemu

2020-12-11 Thread Jan Beulich
On 10.12.2020 16:55, Hongyan Xia wrote: > On Thu, 2020-12-10 at 14:37 +0100, Jan Beulich wrote: >> On 10.12.2020 14:09, Hongyan Xia wrote: >>> On Mon, 2020-09-28 at 12:44 +0200, Jan Beulich wrote: Plus finally there's no point sending the request for the local domain when the domain

Re: [PATCH] x86/HVM: refine when to send mapcache invalidation request to qemu

2020-12-10 Thread Hongyan Xia
On Thu, 2020-12-10 at 14:37 +0100, Jan Beulich wrote: > On 10.12.2020 14:09, Hongyan Xia wrote: > > On Mon, 2020-09-28 at 12:44 +0200, Jan Beulich wrote: > > > Plus finally there's no point sending the request for the local > > > domain > > > when the domain acted upon is a different one. If anythi

Re: [PATCH] x86/HVM: refine when to send mapcache invalidation request to qemu

2020-12-10 Thread Jan Beulich
On 10.12.2020 14:09, Hongyan Xia wrote: > On Mon, 2020-09-28 at 12:44 +0200, Jan Beulich wrote: >> Plus finally there's no point sending the request for the local >> domain >> when the domain acted upon is a different one. If anything that >> domain's >> qemu's mapcache may need invalidating, but i

Re: [PATCH] x86/HVM: refine when to send mapcache invalidation request to qemu

2020-12-10 Thread Hongyan Xia
I came across the same issue when QEMU was holding an extra reference to a page removed from p2m, via XENMEM_add_to_physmap. Please tell me if I am talking nonsense since my knowledge around QEMU invalidation is limited. On Mon, 2020-09-28 at 12:44 +0200, Jan Beulich wrote: > For one it was wrong

Re: [PATCH] x86/HVM: refine when to send mapcache invalidation request to qemu

2020-09-29 Thread Jan Beulich
On 28.09.2020 13:25, Paul Durrant wrote: >> From: Jan Beulich >> Sent: 28 September 2020 11:44 >> >> For one it was wrong to send the request only upon a completed >> hypercall: Even if only part of it completed before getting preempted, >> invalidation ought to occur. Therefore fold the two retur

[PATCH] x86/HVM: refine when to send mapcache invalidation request to qemu

2020-09-28 Thread Jan Beulich
For one it was wrong to send the request only upon a completed hypercall: Even if only part of it completed before getting preempted, invalidation ought to occur. Therefore fold the two return statements. And then XENMEM_decrease_reservation isn't the only means by which pages can get removed from