Re: [PATCH] x86/altp2m: p2m_altp2m_get_or_propagate() should honor ap2m->default_access

2024-02-14 Thread Andrew Cooper
On 06/02/2024 10:08 am, Petr Beneš wrote: > From: Petr Beneš > > This patch addresses a behavior discrepancy in the handling of altp2m views, > where upon the creation and subsequent EPT violation, the page access > permissions were incorrectly inherited from the hostp2m instead of respecting >

Re: [PATCH] x86/altp2m: p2m_altp2m_get_or_propagate() should honor ap2m->default_access

2024-02-08 Thread Tamas K Lengyel
On Thu, Feb 8, 2024 at 9:00 AM Jan Beulich wrote: > > On 08.02.2024 14:45, Tamas K Lengyel wrote: > > On Thu, Feb 8, 2024 at 2:46 AM Jan Beulich wrote: > >> > >> On 08.02.2024 05:32, George Dunlap wrote: > >>> Er, ok, just one more comment: this could allow an altp2m to have more > >>>

Re: [PATCH] x86/altp2m: p2m_altp2m_get_or_propagate() should honor ap2m->default_access

2024-02-08 Thread Jan Beulich
On 08.02.2024 14:45, Tamas K Lengyel wrote: > On Thu, Feb 8, 2024 at 2:46 AM Jan Beulich wrote: >> >> On 08.02.2024 05:32, George Dunlap wrote: >>> Er, ok, just one more comment: this could allow an altp2m to have more >>> permissions than the host; for example, the host p2m entry could be >>>

Re: [PATCH] x86/altp2m: p2m_altp2m_get_or_propagate() should honor ap2m->default_access

2024-02-08 Thread Tamas K Lengyel
On Thu, Feb 8, 2024 at 2:46 AM Jan Beulich wrote: > > On 08.02.2024 05:32, George Dunlap wrote: > > Er, ok, just one more comment: this could allow an altp2m to have more > > permissions than the host; for example, the host p2m entry could be > > p2m_access_r, but if the altp2m's default_access

Re: [PATCH] x86/altp2m: p2m_altp2m_get_or_propagate() should honor ap2m->default_access

2024-02-07 Thread Jan Beulich
On 08.02.2024 05:32, George Dunlap wrote: > Er, ok, just one more comment: this could allow an altp2m to have more > permissions than the host; for example, the host p2m entry could be > p2m_access_r, but if the altp2m's default_access were p2m_access_rw, > it would override that. Is that the

Re: [PATCH] x86/altp2m: p2m_altp2m_get_or_propagate() should honor ap2m->default_access

2024-02-07 Thread George Dunlap
On Thu, Feb 8, 2024 at 9:21 AM Tamas K Lengyel wrote: > > On Wed, Feb 7, 2024 at 5:21 PM Andrew Cooper > wrote: > > > > On 07/02/2024 1:18 am, George Dunlap wrote: > > > On Tue, Feb 6, 2024 at 6:08 PM Petr Beneš wrote: > > >> From: Petr Beneš > > >> > > >> This patch addresses a behavior

Re: [PATCH] x86/altp2m: p2m_altp2m_get_or_propagate() should honor ap2m->default_access

2024-02-07 Thread Tamas K Lengyel
On Wed, Feb 7, 2024 at 5:21 PM Andrew Cooper wrote: > > On 07/02/2024 1:18 am, George Dunlap wrote: > > On Tue, Feb 6, 2024 at 6:08 PM Petr Beneš wrote: > >> From: Petr Beneš > >> > >> This patch addresses a behavior discrepancy in the handling of altp2m > >> views, > >> where upon the

Re: [PATCH] x86/altp2m: p2m_altp2m_get_or_propagate() should honor ap2m->default_access

2024-02-07 Thread Andrew Cooper
On 07/02/2024 1:18 am, George Dunlap wrote: > On Tue, Feb 6, 2024 at 6:08 PM Petr Beneš wrote: >> From: Petr Beneš >> >> This patch addresses a behavior discrepancy in the handling of altp2m views, >> where upon the creation and subsequent EPT violation, the page access >> permissions were

Re: [PATCH] x86/altp2m: p2m_altp2m_get_or_propagate() should honor ap2m->default_access

2024-02-06 Thread George Dunlap
On Tue, Feb 6, 2024 at 6:08 PM Petr Beneš wrote: > > From: Petr Beneš > > This patch addresses a behavior discrepancy in the handling of altp2m views, > where upon the creation and subsequent EPT violation, the page access > permissions were incorrectly inherited from the hostp2m instead of

Re: [PATCH] x86/altp2m: p2m_altp2m_get_or_propagate() should honor ap2m->default_access

2024-02-06 Thread Tamas K Lengyel
On Tue, Feb 6, 2024 at 5:08 AM Petr Beneš wrote: > > From: Petr Beneš > > This patch addresses a behavior discrepancy in the handling of altp2m views, > where upon the creation and subsequent EPT violation, the page access > permissions were incorrectly inherited from the hostp2m instead of

[PATCH] x86/altp2m: p2m_altp2m_get_or_propagate() should honor ap2m->default_access

2024-02-06 Thread Petr Beneš
From: Petr Beneš This patch addresses a behavior discrepancy in the handling of altp2m views, where upon the creation and subsequent EPT violation, the page access permissions were incorrectly inherited from the hostp2m instead of respecting the altp2m default_access. Previously, when a new