Re: [PATCH] x86/asm: ELF metadata for simple cases

2023-02-24 Thread Andrew Cooper
On 20/02/2023 11:51 am, Ross Lagerwall wrote: >> From: Andrew Cooper >> Sent: Monday, February 20, 2023 11:04 AM >> To: Xen-devel >> Cc: Andrew Cooper ; Jan Beulich >> ; Roger Pau Monne ; Wei Liu >> ; Konrad Rzeszutek Wilk ; Ross >> Lagerwall

Re: [PATCH] x86/asm: ELF metadata for simple cases

2023-02-21 Thread Jan Beulich
On 20.02.2023 12:04, Andrew Cooper wrote: > This is generally good practice, and necessary for livepatch binary diffing to > work. > > With this, livepatching of the SVM entry path works. The only complication is > with svm_stgi_label which is only used by oprofile to guestimate (not >

Re: [PATCH] x86/asm: ELF metadata for simple cases

2023-02-21 Thread Jan Beulich
On 20.02.2023 12:51, Ross Lagerwall wrote: >> --- a/xen/arch/x86/clear_page.S >> +++ b/xen/arch/x86/clear_page.S >> @@ -16,3 +16,6 @@ ENTRY(clear_page_sse2) >>   >> sfence >> ret >> + >> +    .type clear_page_sse2, @function >> +    .size clear_page_sse2, . -

Re: [PATCH] x86/asm: ELF metadata for simple cases

2023-02-20 Thread Ross Lagerwall
> From: Andrew Cooper > Sent: Monday, February 20, 2023 11:04 AM > To: Xen-devel > Cc: Andrew Cooper ; Jan Beulich > ; Roger Pau Monne ; Wei Liu > ; Konrad Rzeszutek Wilk ; Ross > Lagerwall > Subject: [PATCH] x86/asm: ELF metadata for simple cases >   > T

[PATCH] x86/asm: ELF metadata for simple cases

2023-02-20 Thread Andrew Cooper
This is generally good practice, and necessary for livepatch binary diffing to work. With this, livepatching of the SVM entry path works. The only complication is with svm_stgi_label which is only used by oprofile to guestimate (not completely correctly) when an NMI hit guest context.