Re: [PATCH] x86/hvm: Fix shifting in stdvga_mem_read()

On 16.05.2020 21:02, Andrew Cooper wrote: > stdvga_mem_read() has a return type of uint8_t, which promotes to int rather > than unsigned int. Shifting by 24 may hit the sign bit. > > Spotted by Coverity. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich

[PATCH] x86/hvm: Fix shifting in stdvga_mem_read()

stdvga_mem_read() has a return type of uint8_t, which promotes to int rather than unsigned int. Shifting by 24 may hit the sign bit. Spotted by Coverity. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné --- xen/arch/x86/hvm/stdvga.c | 2 +- 1 file changed, 1