Re: [PATCH] x86/svm: Provide EXITINFO decodes for MOV CR/DR intercepts

2023-04-06 Thread Andrew Cooper
On 06/04/2023 10:59 am, Jan Beulich wrote: > On 06.04.2023 11:52, Andrew Cooper wrote: >> On 06/04/2023 10:31 am, Jan Beulich wrote: >>> On 05.04.2023 22:44, Andrew Cooper wrote: --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h @@ -450,6 +45

Re: [PATCH] x86/svm: Provide EXITINFO decodes for MOV CR/DR intercepts

2023-04-06 Thread Jan Beulich
On 06.04.2023 11:52, Andrew Cooper wrote: > On 06/04/2023 10:31 am, Jan Beulich wrote: >> On 05.04.2023 22:44, Andrew Cooper wrote: >>> --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h >>> +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h >>> @@ -450,6 +450,11 @@ struct vmcb_struct { >>> >>>

Re: [PATCH] x86/svm: Provide EXITINFO decodes for MOV CR/DR intercepts

2023-04-06 Thread Andrew Cooper
On 06/04/2023 10:31 am, Jan Beulich wrote: > On 05.04.2023 22:44, Andrew Cooper wrote: >> This removes raw number manipulation, and makes the logic easier to follow. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper > Reviewed-by: Jan Beulich Thanks. > > One remark though: > >> ---

Re: [PATCH] x86/svm: Provide EXITINFO decodes for MOV CR/DR intercepts

2023-04-06 Thread Jan Beulich
On 05.04.2023 22:44, Andrew Cooper wrote: > This removes raw number manipulation, and makes the logic easier to follow. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich One remark though: > --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h > +++ b/xen/arch/x86/

[PATCH] x86/svm: Provide EXITINFO decodes for MOV CR/DR intercepts

2023-04-05 Thread Andrew Cooper
This removes raw number manipulation, and makes the logic easier to follow. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/hvm/svm/svm.c | 4 ++-- xen/arch/x86/include/asm/hvm/svm/vmcb.h | 5 + 2 files