Re: [PATCH] x86/timer: Fix boot on Intel systems using ITSSPRC static PIT clock gating

2021-01-27 Thread Andrew Cooper
On 27/01/2021 09:28, Jan Beulich wrote: > On 26.01.2021 18:31, Andrew Cooper wrote: >> On 07/01/2021 13:53, Jan Beulich wrote: + !((hpet_cfg = hpet_read32(HPET_CFG)) & HPET_CFG_LEGACY) ) +{ +unsigned int c0_cfg, ticks, count; + +/* Stop the main

Re: [PATCH] x86/timer: Fix boot on Intel systems using ITSSPRC static PIT clock gating

2021-01-27 Thread Jan Beulich
On 26.01.2021 18:31, Andrew Cooper wrote: > On 07/01/2021 13:53, Jan Beulich wrote: >>> + !((hpet_cfg = hpet_read32(HPET_CFG)) & HPET_CFG_LEGACY) ) >>> +{ >>> +unsigned int c0_cfg, ticks, count; >>> + >>> +/* Stop the main counter. */ >>> +hpet_write32(hpet_cfg

Re: [PATCH] x86/timer: Fix boot on Intel systems using ITSSPRC static PIT clock gating

2021-01-26 Thread Andrew Cooper
On 07/01/2021 13:53, Jan Beulich wrote: >> + !((hpet_cfg = hpet_read32(HPET_CFG)) & HPET_CFG_LEGACY) ) >> +{ >> +unsigned int c0_cfg, ticks, count; >> + >> +/* Stop the main counter. */ >> +hpet_write32(hpet_cfg & ~HPET_CFG_ENABLE, HPET_CFG); >> + >> +/*

Re: [PATCH] x86/timer: Fix boot on Intel systems using ITSSPRC static PIT clock gating

2021-01-08 Thread Jason Andryuk
On Wed, Jan 6, 2021 at 8:06 PM Andrew Cooper wrote: > > Recent Intel client devices have disabled the legacy PIT for powersaving > reasons, breaking compatibility with a traditional IBM PC. Xen depends on a > legacy timer interrupt to check that the IO-APIC/PIC routing is configured > correctly,

Re: [PATCH] x86/timer: Fix boot on Intel systems using ITSSPRC static PIT clock gating

2021-01-07 Thread Jan Beulich
On 07.01.2021 02:06, Andrew Cooper wrote: > Slightly RFC. On older platforms this does generate some spurious PIC > interrupts during boot, but they're benign. I was hoping to have time to fix > those too, but I'm getting an increasing number of requests to post this > patch. We still will want

[PATCH] x86/timer: Fix boot on Intel systems using ITSSPRC static PIT clock gating

2021-01-06 Thread Andrew Cooper
Recent Intel client devices have disabled the legacy PIT for powersaving reasons, breaking compatibility with a traditional IBM PC. Xen depends on a legacy timer interrupt to check that the IO-APIC/PIC routing is configured correctly, and fails to boot with: (XEN)