Re: [PATCH] x86: conditionalize workaround for build issue with GNU ld 2.37

2021-09-14 Thread Roger Pau Monné
On Mon, Sep 13, 2021 at 05:07:54PM +0200, Jan Beulich wrote: > On 13.09.2021 16:33, Roger Pau Monné wrote: > > On Mon, Sep 13, 2021 at 04:05:15PM +0200, Jan Beulich wrote: > >> On 13.09.2021 15:37, Roger Pau Monné wrote: > >>> On Thu, Sep 09, 2021 at 04:35:49PM +0200, Jan Beulich wrote: > I ha

Re: [PATCH] x86: conditionalize workaround for build issue with GNU ld 2.37

2021-09-13 Thread Roger Pau Monné
On Mon, Sep 13, 2021 at 05:10:54PM +0200, Jan Beulich wrote: > On 13.09.2021 16:33, Roger Pau Monné wrote: > > On Mon, Sep 13, 2021 at 04:05:15PM +0200, Jan Beulich wrote: > >> On 13.09.2021 15:37, Roger Pau Monné wrote: > --- a/xen/arch/x86/Makefile > +++ b/xen/arch/x86/Makefile > @

Re: [PATCH] x86: conditionalize workaround for build issue with GNU ld 2.37

2021-09-13 Thread Jan Beulich
On 13.09.2021 16:33, Roger Pau Monné wrote: > On Mon, Sep 13, 2021 at 04:05:15PM +0200, Jan Beulich wrote: >> On 13.09.2021 15:37, Roger Pau Monné wrote: --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -92,10 +92,16 @@ efi-$(CONFIG_PV_SHIM_EXCLUSIVE) := ifneq

Re: [PATCH] x86: conditionalize workaround for build issue with GNU ld 2.37

2021-09-13 Thread Jan Beulich
On 13.09.2021 16:33, Roger Pau Monné wrote: > On Mon, Sep 13, 2021 at 04:05:15PM +0200, Jan Beulich wrote: >> On 13.09.2021 15:37, Roger Pau Monné wrote: >>> On Thu, Sep 09, 2021 at 04:35:49PM +0200, Jan Beulich wrote: I haven't been able to find an environment where I could actually try

Re: [PATCH] x86: conditionalize workaround for build issue with GNU ld 2.37

2021-09-13 Thread Jan Beulich
On 13.09.2021 16:20, Roger Pau Monné wrote: > On Thu, Sep 09, 2021 at 04:35:49PM +0200, Jan Beulich wrote: >> .PHONY: clean >> clean:: >> -rm -f *.lds *.new boot/*.o boot/*~ boot/core boot/mkelf32 >> +rm -f ???.lds *.new .check.* boot/*.o boot/*~ boot/core boot/mkelf32 > > Forgot to ment

Re: [PATCH] x86: conditionalize workaround for build issue with GNU ld 2.37

2021-09-13 Thread Roger Pau Monné
On Mon, Sep 13, 2021 at 04:05:15PM +0200, Jan Beulich wrote: > On 13.09.2021 15:37, Roger Pau Monné wrote: > > On Thu, Sep 09, 2021 at 04:35:49PM +0200, Jan Beulich wrote: > >> I haven't been able to find an environment where I could actually try > >> with lld (ld.lld); all testing was with GNU ld

Re: [PATCH] x86: conditionalize workaround for build issue with GNU ld 2.37

2021-09-13 Thread Roger Pau Monné
On Thu, Sep 09, 2021 at 04:35:49PM +0200, Jan Beulich wrote: > .PHONY: clean > clean:: > - rm -f *.lds *.new boot/*.o boot/*~ boot/core boot/mkelf32 > + rm -f ???.lds *.new .check.* boot/*.o boot/*~ boot/core boot/mkelf32 Forgot to mention in my previous reply, but what's the point of us

Re: [PATCH] x86: conditionalize workaround for build issue with GNU ld 2.37

2021-09-13 Thread Jan Beulich
On 13.09.2021 15:37, Roger Pau Monné wrote: > On Thu, Sep 09, 2021 at 04:35:49PM +0200, Jan Beulich wrote: >> I haven't been able to find an environment where I could actually try >> with lld (ld.lld); all testing was with GNU ld (ld.bfd). > > Thanks for fixing this. I've been able to test with LL

Re: [PATCH] x86: conditionalize workaround for build issue with GNU ld 2.37

2021-09-13 Thread Roger Pau Monné
On Thu, Sep 09, 2021 at 04:35:49PM +0200, Jan Beulich wrote: > While LLVM's lld is supposed to be a drop-in replacement for GNU ld [1], > it appears to not understand quoted section names as operands to e.g. > ADDR(). Therefore the original workaround broke the build in > environments where ld is a

[PATCH] x86: conditionalize workaround for build issue with GNU ld 2.37

2021-09-09 Thread Jan Beulich
While LLVM's lld is supposed to be a drop-in replacement for GNU ld [1], it appears to not understand quoted section names as operands to e.g. ADDR(). Therefore the original workaround broke the build in environments where ld is actually LLVM's, like on FreeBSD. Fixes: 58ad654ebce7 ("x86: work aro