[PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

2023-06-01 Thread Michal Orzel
There are implementations of the PL011 that can only handle 32-bit accesses (i.e. no 16-bit or 8-bit), usually advertised by 'reg-io-width' dt property set to 4. On such UARTs, the current early printk code for arm64 does not work. To fix this issue, make all the accesses to be 32-bit by using ldr,

RE: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

2023-06-01 Thread Henry Wang
Hi Michal, > -Original Message- > Subject: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader > compatibility > > There are implementations of the PL011 that can only handle 32-bit > accesses (i.e. no 16-bit or 8-bit), usually advertised by 'reg-io-widt

Re: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

2023-06-01 Thread Bertrand Marquis
Hi Michal, > On 1 Jun 2023, at 10:50, Michal Orzel wrote: > > There are implementations of the PL011 that can only handle 32-bit > accesses (i.e. no 16-bit or 8-bit), usually advertised by 'reg-io-width' > dt property set to 4. On such UARTs, the current early printk code for > arm64 does not wo

Re: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

2023-06-01 Thread Michal Orzel
Hi Bertrand, On 01/06/2023 12:19, Bertrand Marquis wrote: > > > Hi Michal, > >> On 1 Jun 2023, at 10:50, Michal Orzel wrote: >> >> There are implementations of the PL011 that can only handle 32-bit >> accesses (i.e. no 16-bit or 8-bit), usually advertised by 'reg-io-width' >> dt property set t

Re: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

2023-06-01 Thread Julien Grall
Hi, Sorry for the formatting. On Thu, 1 Jun 2023 at 12:31, Michal Orzel wrote: > Hi Bertrand, > > On 01/06/2023 12:19, Bertrand Marquis wrote: > > > > > > Hi Michal, > > > >> On 1 Jun 2023, at 10:50, Michal Orzel wrote: > >> > >> There are implementations of the PL011 that can only handle 32-b

Re: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

2023-06-01 Thread Michal Orzel
Hi Julien, On 01/06/2023 13:12, Julien Grall wrote: > > > > Hi, > > Sorry for the formatting. > > On Thu, 1 Jun 2023 at 12:31, Michal Orzel > wrote: > > Hi Bertrand, > > On 01/06/2023 12:19, Bertrand Marquis wrote: > > > > > > Hi Micha

Re: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

2023-06-01 Thread Julien Grall
On Thu, 1 Jun 2023 at 13:48, Michal Orzel wrote: > Hi Julien, > > On 01/06/2023 13:12, Julien Grall wrote: > > > > > > > > Hi, > > > > Sorry for the formatting. > > > > On Thu, 1 Jun 2023 at 12:31, Michal Orzel michal.or...@amd.com>> wrote: > > > > Hi Bertrand, > > > > On 01/06/2023 12:1

Re: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

2023-06-01 Thread Michal Orzel
On 01/06/2023 14:17, Julien Grall wrote: > > > > > > On Thu, 1 Jun 2023 at 13:48, Michal Orzel > wrote: > > Hi Julien, > > On 01/06/2023 13:12, Julien Grall wrote: > >        > > > > > > Hi, > > > > Sorry for the formattin

Re: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

2023-06-05 Thread Julien Grall
Hi, On 01/06/2023 13:38, Michal Orzel wrote: On 01/06/2023 14:17, Julien Grall wrote: On Thu, 1 Jun 2023 at 13:48, Michal Orzel mailto:michal.or...@amd.com>> wrote: Hi Julien, On 01/06/2023 13:12, Julien Grall wrote: > > > > Hi, > > Sorry

Re: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

2023-06-06 Thread Michal Orzel
Hi Julien, On 05/06/2023 20:34, Julien Grall wrote: > > > Hi, > > On 01/06/2023 13:38, Michal Orzel wrote: >> >> On 01/06/2023 14:17, Julien Grall wrote: >>> >>> >>> >>> >>> >>> On Thu, 1 Jun 2023 at 13:48, Michal Orzel >> > wrote: >>> >>> Hi Julien, >>> >>>

Re: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

2023-06-06 Thread Julien Grall
On 06/06/2023 08:04, Michal Orzel wrote: Hi Julien, Hi Michal, On 05/06/2023 20:34, Julien Grall wrote: I can think of the following patches: 1) Use correct accessors for early pl011 on arm32 and arm64 - this would use the accessors depending on the given register size (ldrh, strh, strb)