Re: [PATCH] xen/arm: fix gnttab_need_iommu_mapping

2021-02-09 Thread Rahul Singh
Hello Julien, > On 8 Feb 2021, at 6:49 pm, Julien Grall wrote: > > > > On 08/02/2021 18:19, Rahul Singh wrote: >> Hello Julien, > > Hi Rahul, > >>> On 8 Feb 2021, at 6:11 pm, Julien Grall wrote: >>> >>> >>> >>> On 08/02/2021 18:06, Rahul Singh wrote: > On 6 Feb 2021, at 12:38 am,

Re: [PATCH] xen/arm: fix gnttab_need_iommu_mapping

2021-02-08 Thread Julien Grall
On 08/02/2021 18:19, Rahul Singh wrote: Hello Julien, Hi Rahul, On 8 Feb 2021, at 6:11 pm, Julien Grall wrote: On 08/02/2021 18:06, Rahul Singh wrote: On 6 Feb 2021, at 12:38 am, Stefano Stabellini wrote: Commit 91d4eca7add broke gnttab_need_iommu_mapping on ARM. The offending

Re: [PATCH] xen/arm: fix gnttab_need_iommu_mapping

2021-02-08 Thread Rahul Singh
Hello Julien, > On 8 Feb 2021, at 6:11 pm, Julien Grall wrote: > > > > On 08/02/2021 18:06, Rahul Singh wrote: >>> On 6 Feb 2021, at 12:38 am, Stefano Stabellini >>> wrote: >>> >>> Commit 91d4eca7add broke gnttab_need_iommu_mapping on ARM. >>> The offending chunk is: >>> >>> #define

Re: [PATCH] xen/arm: fix gnttab_need_iommu_mapping

2021-02-08 Thread Julien Grall
On 08/02/2021 18:06, Rahul Singh wrote: On 6 Feb 2021, at 12:38 am, Stefano Stabellini wrote: Commit 91d4eca7add broke gnttab_need_iommu_mapping on ARM. The offending chunk is: #define gnttab_need_iommu_mapping(d)\ -(is_domain_direct_mapped(d) && need_iommu(d)) +

Re: [PATCH] xen/arm: fix gnttab_need_iommu_mapping

2021-02-08 Thread Rahul Singh
Hello Stefano, > On 6 Feb 2021, at 12:38 am, Stefano Stabellini wrote: > > Commit 91d4eca7add broke gnttab_need_iommu_mapping on ARM. > The offending chunk is: > > #define gnttab_need_iommu_mapping(d)\ > -(is_domain_direct_mapped(d) && need_iommu(d)) > +

Re: [PATCH] xen/arm: fix gnttab_need_iommu_mapping

2021-02-08 Thread Stefano Stabellini
On Sat, 6 Feb 2021, Julien Grall wrote: > Hi Stefano, > > On 06/02/2021 00:38, Stefano Stabellini wrote: > > Commit 91d4eca7add broke gnttab_need_iommu_mapping on ARM. > > Doh :/. > > > The offending chunk is: > > > #define gnttab_need_iommu_mapping(d)\ > > -

Re: [PATCH] xen/arm: fix gnttab_need_iommu_mapping

2021-02-08 Thread Julien Grall
Hi, On 06/02/2021 11:09, Julien Grall wrote: Hi Stefano, On 06/02/2021 00:38, Stefano Stabellini wrote: Commit 91d4eca7add broke gnttab_need_iommu_mapping on ARM. Doh :/. The offending chunk is: >   #define gnttab_need_iommu_mapping(d)    \ -    (is_domain_direct_mapped(d)

Re: [PATCH] xen/arm: fix gnttab_need_iommu_mapping

2021-02-06 Thread Julien Grall
Hi Stefano, On 06/02/2021 00:38, Stefano Stabellini wrote: Commit 91d4eca7add broke gnttab_need_iommu_mapping on ARM. Doh :/. The offending chunk is: > #define gnttab_need_iommu_mapping(d)\ -(is_domain_direct_mapped(d) && need_iommu(d)) +

[PATCH] xen/arm: fix gnttab_need_iommu_mapping

2021-02-05 Thread Stefano Stabellini
Commit 91d4eca7add broke gnttab_need_iommu_mapping on ARM. The offending chunk is: #define gnttab_need_iommu_mapping(d)\ -(is_domain_direct_mapped(d) && need_iommu(d)) +(is_domain_direct_mapped(d) && need_iommu_pt_sync(d)) On ARM we need gnttab_need_iommu_mapping to