Re: [PATCH] xen/arm: vpci: Remove PCI I/O ranges property value

2021-12-17 Thread Julien Grall
Hi Rahul, I have a few comments on top of what Stefano already wrote. On 14/12/2021 10:45, Rahul Singh wrote: IO ports on ARM don't exist so all IO ports related hypercalls are going to fail on ARM when we passthrough a PCI device. Well. Arm doesn't have specific instructions to access I/O po

Re: [PATCH] xen/arm: vpci: Remove PCI I/O ranges property value

2021-12-17 Thread Rahul Singh
Hi Stefano, > On 16 Dec 2021, at 9:48 pm, Stefano Stabellini wrote: > > On Thu, 16 Dec 2021, Rahul Singh wrote: >> Hi Stefano, >> >>> On 16 Dec 2021, at 2:33 am, Stefano Stabellini >>> wrote: >>> >>> On Tue, 14 Dec 2021, Rahul Singh wrote: IO ports on ARM don't exist so all IO ports rel

Re: [PATCH] xen/arm: vpci: Remove PCI I/O ranges property value

2021-12-16 Thread Stefano Stabellini
On Thu, 16 Dec 2021, Rahul Singh wrote: > Hi Stefano, > > > On 16 Dec 2021, at 2:33 am, Stefano Stabellini > > wrote: > > > > On Tue, 14 Dec 2021, Rahul Singh wrote: > >> IO ports on ARM don't exist so all IO ports related hypercalls are going > >> to fail on ARM when we passthrough a PCI devic

Re: [PATCH] xen/arm: vpci: Remove PCI I/O ranges property value

2021-12-16 Thread Rahul Singh
Hi Stefano, > On 16 Dec 2021, at 2:33 am, Stefano Stabellini wrote: > > On Tue, 14 Dec 2021, Rahul Singh wrote: >> IO ports on ARM don't exist so all IO ports related hypercalls are going >> to fail on ARM when we passthrough a PCI device. >> Failure of xc_domain_ioport_permission(..) would turn

Re: [PATCH] xen/arm: vpci: Remove PCI I/O ranges property value

2021-12-15 Thread Stefano Stabellini
On Tue, 14 Dec 2021, Rahul Singh wrote: > IO ports on ARM don't exist so all IO ports related hypercalls are going > to fail on ARM when we passthrough a PCI device. > Failure of xc_domain_ioport_permission(..) would turn into a critical > failure at domain creation. We need to avoid this outcome,

[PATCH] xen/arm: vpci: Remove PCI I/O ranges property value

2021-12-14 Thread Rahul Singh
IO ports on ARM don't exist so all IO ports related hypercalls are going to fail on ARM when we passthrough a PCI device. Failure of xc_domain_ioport_permission(..) would turn into a critical failure at domain creation. We need to avoid this outcome, instead we want to continue with domain creation