On 14.06.2023 11:21, Andrew Cooper wrote:
> On 14/06/2023 7:52 am, Jan Beulich wrote:
>> On 13.06.2023 21:47, Roberto Bagnara wrote:
>>> On 13/06/23 19:45, Andrew Cooper wrote:
On 13/06/2023 6:39 pm, Julien Grall wrote:
> Hi,
>
> On 13/06/2023 17:22, Andrew Cooper wrote:
>> The
On 14/06/2023 7:52 am, Jan Beulich wrote:
> On 13.06.2023 21:47, Roberto Bagnara wrote:
>> On 13/06/23 19:45, Andrew Cooper wrote:
>>> On 13/06/2023 6:39 pm, Julien Grall wrote:
Hi,
On 13/06/2023 17:22, Andrew Cooper wrote:
> These are disliked specifically by MISRA, but they als
Hi Jan,
On 14/06/2023 07:59, Jan Beulich wrote:
On 13.06.2023 18:22, Andrew Cooper wrote:
These are disliked specifically by MISRA, but they also interfere with code
legibility by hiding control flow. Expand and drop them.
* Rearrange the order of actions to write into rc, then render rc in
On 13.06.2023 18:22, Andrew Cooper wrote:
> These are disliked specifically by MISRA, but they also interfere with code
> legibility by hiding control flow. Expand and drop them.
>
> * Rearrange the order of actions to write into rc, then render rc in the
>gdprintk().
> * Drop redundant "rc
On 13.06.2023 21:47, Roberto Bagnara wrote:
> On 13/06/23 19:45, Andrew Cooper wrote:
>> On 13/06/2023 6:39 pm, Julien Grall wrote:
>>> Hi,
>>>
>>> On 13/06/2023 17:22, Andrew Cooper wrote:
These are disliked specifically by MISRA, but they also interfere
with code
>>>
>>> Please explicit
On 13/06/23 19:45, Andrew Cooper wrote:
On 13/06/2023 6:39 pm, Julien Grall wrote:
Hi,
On 13/06/2023 17:22, Andrew Cooper wrote:
These are disliked specifically by MISRA, but they also interfere
with code
Please explicitly name the rule.
I can't remember it off the top of my head.
Stefano
On 13/06/2023 6:39 pm, Julien Grall wrote:
> Hi,
>
> On 13/06/2023 17:22, Andrew Cooper wrote:
>> These are disliked specifically by MISRA, but they also interfere
>> with code
>
> Please explicitly name the rule.
I can't remember it off the top of my head.
Stefano/Bertrand?
>
>> legibility by h
Hi,
On 13/06/2023 17:22, Andrew Cooper wrote:
These are disliked specifically by MISRA, but they also interfere with code
Please explicitly name the rule.
legibility by hiding control flow. Expand and drop them.
* Rearrange the order of actions to write into rc, then render rc in the
These are disliked specifically by MISRA, but they also interfere with code
legibility by hiding control flow. Expand and drop them.
* Rearrange the order of actions to write into rc, then render rc in the
gdprintk().
* Drop redundant "rc = rc" assignments
* Switch to using %pd for renderin
