Re: [PATCH] xen/iommu: smmu: Use 1UL << 31 rather than 1 << 31

2021-01-13 Thread Julien Grall
Hi Hans, Sorry for the late reply. On 24/12/2020 19:48, Hans van Kranenburg wrote: On 12/24/20 4:24 PM, Julien Grall wrote: From: Julien Grall Replace all the use of 1 << 31 with 1UL << 31 to prevent undefined behavior in the SMMU driver. You're replacing it by 1U, not 1UL, in the patch

Re: [PATCH] xen/iommu: smmu: Use 1UL << 31 rather than 1 << 31

2021-01-04 Thread Jan Beulich
On 24.12.2020 16:24, Julien Grall wrote: > From: Julien Grall > > Replace all the use of 1 << 31 with 1UL << 31 to prevent undefined > behavior in the SMMU driver. > > Signed-off-by: Julien Grall With, as already pointed out by Hans, 1UL replaced by 1U in title and description Reviewed-by:

Re: [PATCH] xen/iommu: smmu: Use 1UL << 31 rather than 1 << 31

2020-12-24 Thread Hans van Kranenburg
On 12/24/20 4:24 PM, Julien Grall wrote: > From: Julien Grall > > Replace all the use of 1 << 31 with 1UL << 31 to prevent undefined > behavior in the SMMU driver. You're replacing it by 1U, not 1UL, in the patch below. Hans > Signed-off-by: Julien Grall > --- >

[PATCH] xen/iommu: smmu: Use 1UL << 31 rather than 1 << 31

2020-12-24 Thread Julien Grall
From: Julien Grall Replace all the use of 1 << 31 with 1UL << 31 to prevent undefined behavior in the SMMU driver. Signed-off-by: Julien Grall --- xen/drivers/passthrough/arm/smmu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c