Re: [PATCH] xen/vpci: msix: move x86 specific code to x86 file

Hi Jan > On 21 Dec 2021, at 7:41 am, Jan Beulich wrote: > > On 17.12.2021 15:32, Julien Grall wrote: >> On 16/12/2021 13:37, Jan Beulich wrote: >>> On 16.12.2021 12:01, Roger Pau Monné wrote: On Thu, Dec 16, 2021 at 10:18:32AM +, Rahul Singh wrote: >> On 14 Dec 2021, at 12:37 pm, Ro

Re: [PATCH] xen/vpci: msix: move x86 specific code to x86 file

On 17.12.2021 15:32, Julien Grall wrote: > On 16/12/2021 13:37, Jan Beulich wrote: >> On 16.12.2021 12:01, Roger Pau Monné wrote: >>> On Thu, Dec 16, 2021 at 10:18:32AM +, Rahul Singh wrote: > On 14 Dec 2021, at 12:37 pm, Roger Pau Monné wrote: > On Tue, Dec 14, 2021 at 10:45:17AM +000

Re: [PATCH] xen/vpci: msix: move x86 specific code to x86 file

Hi Julien > On 17 Dec 2021, at 2:32 pm, Julien Grall wrote: > > Hi Jan, > > On 16/12/2021 13:37, Jan Beulich wrote: >> On 16.12.2021 12:01, Roger Pau Monné wrote: >>> On Thu, Dec 16, 2021 at 10:18:32AM +, Rahul Singh wrote: Hi Roger, Thanks for reviewing the code.

Re: [PATCH] xen/vpci: msix: move x86 specific code to x86 file

Hi Jan, On 16/12/2021 13:37, Jan Beulich wrote: On 16.12.2021 12:01, Roger Pau Monné wrote: On Thu, Dec 16, 2021 at 10:18:32AM +, Rahul Singh wrote: Hi Roger, Thanks for reviewing the code. On 14 Dec 2021, at 12:37 pm, Roger Pau Monné wrote: On Tue, Dec 14, 2021 at 10:45:17AM +, R

Re: [PATCH] xen/vpci: msix: move x86 specific code to x86 file

On 16.12.2021 12:01, Roger Pau Monné wrote: > On Thu, Dec 16, 2021 at 10:18:32AM +, Rahul Singh wrote: >> Hi Roger, >> >> Thanks for reviewing the code. >> >>> On 14 Dec 2021, at 12:37 pm, Roger Pau Monné wrote: >>> >>> On Tue, Dec 14, 2021 at 10:45:17AM +, Rahul Singh wrote: +

Re: [PATCH] xen/vpci: msix: move x86 specific code to x86 file

On Thu, Dec 16, 2021 at 10:18:32AM +, Rahul Singh wrote: > Hi Roger, > > Thanks for reviewing the code. > > > On 14 Dec 2021, at 12:37 pm, Roger Pau Monné wrote: > > > > On Tue, Dec 14, 2021 at 10:45:17AM +, Rahul Singh wrote: > >> + unsigned long *data) > >> { > >> -co

Re: [PATCH] xen/vpci: msix: move x86 specific code to x86 file

Hi Jan, Thanks for reviewing the code. > On 14 Dec 2021, at 2:15 pm, Jan Beulich wrote: > > On 14.12.2021 11:45, Rahul Singh wrote: >> --- a/xen/drivers/vpci/msix.c >> +++ b/xen/drivers/vpci/msix.c >> @@ -17,15 +17,24 @@ >> * License along with this program; If not, see >>

Re: [PATCH] xen/vpci: msix: move x86 specific code to x86 file

Hi Roger, Thanks for reviewing the code. > On 14 Dec 2021, at 12:37 pm, Roger Pau Monné wrote: > > On Tue, Dec 14, 2021 at 10:45:17AM +, Rahul Singh wrote: >> vpci/msix.c file will be used for arm architecture when vpci msix >> support will be added to ARM, but there is x86 specific code in

Re: [PATCH] xen/vpci: msix: move x86 specific code to x86 file

On 14.12.2021 11:45, Rahul Singh wrote: > --- a/xen/drivers/vpci/msix.c > +++ b/xen/drivers/vpci/msix.c > @@ -17,15 +17,24 @@ > * License along with this program; If not, see > . > */ > > +#include > #include > #include > > -#include > #include > > -

Re: [PATCH] xen/vpci: msix: move x86 specific code to x86 file

On Tue, Dec 14, 2021 at 10:45:17AM +, Rahul Singh wrote: > vpci/msix.c file will be used for arm architecture when vpci msix > support will be added to ARM, but there is x86 specific code in this > file. > > Move x86 specific code to the x86_msix.c file to make sure common code > will be used

[PATCH] xen/vpci: msix: move x86 specific code to x86 file

vpci/msix.c file will be used for arm architecture when vpci msix support will be added to ARM, but there is x86 specific code in this file. Move x86 specific code to the x86_msix.c file to make sure common code will be used for other architecture. No functional change intended. Signed-off-by: R