Re: [PATCH] xen/xmalloc: XMEM_POOL_POISON improvements

2023-12-21 Thread Andrew Cooper
On 20/12/2023 9:51 pm, Julien Grall wrote: > Hi Andrew, > > On 20/12/2023 21:47, Andrew Cooper wrote: >> When in use, the spew: >> >>    (XEN) Assertion '!memchr_inv(b->ptr.buffer + MIN_BLOCK_SIZE, >> POISON_BYTE, (b->size & BLOCK_SIZE_MASK) - MIN_BLOCK_SIZE)' failed at >> common/xmalloc_tlsf.c:246

Re: [PATCH] xen/xmalloc: XMEM_POOL_POISON improvements

2023-12-20 Thread Julien Grall
Hi Andrew, On 20/12/2023 21:47, Andrew Cooper wrote: When in use, the spew: (XEN) Assertion '!memchr_inv(b->ptr.buffer + MIN_BLOCK_SIZE, POISON_BYTE, (b->size & BLOCK_SIZE_MASK) - MIN_BLOCK_SIZE)' failed at common/xmalloc_tlsf.c:246 is unweidly and likely meaningless to non-Xen developers.

[PATCH] xen/xmalloc: XMEM_POOL_POISON improvements

2023-12-20 Thread Andrew Cooper
When in use, the spew: (XEN) Assertion '!memchr_inv(b->ptr.buffer + MIN_BLOCK_SIZE, POISON_BYTE, (b->size & BLOCK_SIZE_MASK) - MIN_BLOCK_SIZE)' failed at common/xmalloc_tlsf.c:246 is unweidly and likely meaningless to non-Xen developers. Therefore: * Switch to IS_ENABLED(). There's no nee