Re: [PATCH] xen: don't require virtio with grants for non-PV guests

2022-06-15 Thread Stefano Stabellini
On Wed, 15 Jun 2022, Juergen Gross wrote: > Commit fa1f57421e0b ("xen/virtio: Enable restricted memory access using > Xen grant mappings") introduced a new requirement for using virtio > devices: the backend now needs to support the VIRTIO_F_ACCESS_PLATFORM > feature. > > This is an undue requirem

Re: [PATCH] xen: don't require virtio with grants for non-PV guests

2022-06-15 Thread Oleksandr
On 15.06.22 11:48, Juergen Gross wrote: Hello Juergen Commit fa1f57421e0b ("xen/virtio: Enable restricted memory access using Xen grant mappings") introduced a new requirement for using virtio devices: the backend now needs to support the VIRTIO_F_ACCESS_PLATFORM feature. This is an undue re

Re: [PATCH] xen: don't require virtio with grants for non-PV guests

2022-06-15 Thread Juergen Gross
On 15.06.22 15:43, Christoph Hellwig wrote: On Wed, Jun 15, 2022 at 02:53:54PM +0200, Juergen Gross wrote: On 15.06.22 13:54, Christoph Hellwig wrote: On Wed, Jun 15, 2022 at 01:39:01PM +0200, Juergen Gross wrote: No, it doesn't. I'm working on a qemu patch series enabling the qemu based backe

Re: [PATCH] xen: don't require virtio with grants for non-PV guests

2022-06-15 Thread Christoph Hellwig
On Wed, Jun 15, 2022 at 02:53:54PM +0200, Juergen Gross wrote: > On 15.06.22 13:54, Christoph Hellwig wrote: > > On Wed, Jun 15, 2022 at 01:39:01PM +0200, Juergen Gross wrote: > > > No, it doesn't. I'm working on a qemu patch series enabling the qemu > > > based backends to support grants with virt

Re: [PATCH] xen: don't require virtio with grants for non-PV guests

2022-06-15 Thread Juergen Gross
On 15.06.22 13:54, Christoph Hellwig wrote: On Wed, Jun 15, 2022 at 01:39:01PM +0200, Juergen Gross wrote: No, it doesn't. I'm working on a qemu patch series enabling the qemu based backends to support grants with virtio. The code is working fine on x86, too (apart from the fact that the backend

Re: [PATCH] xen: don't require virtio with grants for non-PV guests

2022-06-15 Thread Christoph Hellwig
On Wed, Jun 15, 2022 at 01:39:01PM +0200, Juergen Gross wrote: > No, it doesn't. I'm working on a qemu patch series enabling the qemu > based backends to support grants with virtio. The code is working fine > on x86, too (apart from the fact that the backends aren't ready yet). The code right now

Re: [PATCH] xen: don't require virtio with grants for non-PV guests

2022-06-15 Thread Juergen Gross
On 15.06.22 13:28, Christoph Hellwig wrote: On Wed, Jun 15, 2022 at 01:26:27PM +0200, Juergen Gross wrote: On 15.06.22 13:24, Christoph Hellwig wrote: I don't think this command line mess is a good idea. Instead the brand new grant devices need to be properly advertised in the device tree, and

Re: [PATCH] xen: don't require virtio with grants for non-PV guests

2022-06-15 Thread Christoph Hellwig
On Wed, Jun 15, 2022 at 01:26:27PM +0200, Juergen Gross wrote: > On 15.06.22 13:24, Christoph Hellwig wrote: > > I don't think this command line mess is a good idea. Instead the > > brand new grant devices need to be properly advertised in the device > > tree, and any device that isn't a grant dev

Re: [PATCH] xen: don't require virtio with grants for non-PV guests

2022-06-15 Thread Juergen Gross
On 15.06.22 13:24, Christoph Hellwig wrote: I don't think this command line mess is a good idea. Instead the brand new grant devices need to be properly advertised in the device tree, and any device that isn't a grant device doesn't need VIRTIO_F_ACCESS_PLATFORM. No need for a command line or u

Re: [PATCH] xen: don't require virtio with grants for non-PV guests

2022-06-15 Thread Christoph Hellwig
I don't think this command line mess is a good idea. Instead the brand new grant devices need to be properly advertised in the device tree, and any device that isn't a grant device doesn't need VIRTIO_F_ACCESS_PLATFORM. No need for a command line or user intervention.

Re: [PATCH] xen: don't require virtio with grants for non-PV guests

2022-06-15 Thread Juergen Gross
On 15.06.22 11:25, Viresh Kumar wrote: On 15-06-22, 10:48, Juergen Gross wrote: Commit fa1f57421e0b ("xen/virtio: Enable restricted memory access using Xen grant mappings") introduced a new requirement for using virtio devices: the backend now needs to support the VIRTIO_F_ACCESS_PLATFORM featur

Re: [PATCH] xen: don't require virtio with grants for non-PV guests

2022-06-15 Thread Viresh Kumar
On 15-06-22, 10:48, Juergen Gross wrote: > Commit fa1f57421e0b ("xen/virtio: Enable restricted memory access using > Xen grant mappings") introduced a new requirement for using virtio > devices: the backend now needs to support the VIRTIO_F_ACCESS_PLATFORM > feature. > > This is an undue requireme

[PATCH] xen: don't require virtio with grants for non-PV guests

2022-06-15 Thread Juergen Gross
Commit fa1f57421e0b ("xen/virtio: Enable restricted memory access using Xen grant mappings") introduced a new requirement for using virtio devices: the backend now needs to support the VIRTIO_F_ACCESS_PLATFORM feature. This is an undue requirement for non-PV guests, as those can be operated with e