Re: [PATCH-for-9.0 v2 10/19] hw/xen: Rename 'ram_memory' global variable as 'xen_memory'

2024-03-06 Thread Philippe Mathieu-Daudé
On 14/11/23 16:49, David Woodhouse wrote: On 14 November 2023 09:38:06 GMT-05:00, "Philippe Mathieu-Daudé" wrote: To avoid a potential global variable shadow in hw/i386/pc_piix.c::pc_init1(), rename Xen's "ram_memory" as "xen_memory". Signed-off-by: Philippe Mathieu-Daudé Well OK, but

Re: [PATCH-for-9.0 v2 10/19] hw/xen: Rename 'ram_memory' global variable as 'xen_memory'

2023-11-14 Thread David Woodhouse
On 14 November 2023 09:38:06 GMT-05:00, "Philippe Mathieu-Daudé" wrote: >To avoid a potential global variable shadow in >hw/i386/pc_piix.c::pc_init1(), rename Xen's >"ram_memory" as "xen_memory". > >Signed-off-by: Philippe Mathieu-Daudé Well OK, but aren't you going to be coming back later to

[PATCH-for-9.0 v2 10/19] hw/xen: Rename 'ram_memory' global variable as 'xen_memory'

2023-11-14 Thread Philippe Mathieu-Daudé
To avoid a potential global variable shadow in hw/i386/pc_piix.c::pc_init1(), rename Xen's "ram_memory" as "xen_memory". Signed-off-by: Philippe Mathieu-Daudé --- include/hw/xen/xen-hvm-common.h | 2 +- hw/arm/xen_arm.c| 6 +++--- hw/i386/xen/xen-hvm.c | 10