Re: [PATCH 02/11] x86/vPMU: avoid effectively open-coding xzalloc_flex_struct()

2021-04-08 Thread Jan Beulich
On 08.04.2021 14:25, Andrew Cooper wrote: > On 08/04/2021 13:17, Jan Beulich wrote: >> There is a difference in generated code: xzalloc_bytes() forces >> SMP_CACHE_BYTES alignment. I think we not only don't need this here, but >> actually don't want it. >> >> Signed-off-by: Jan Beulich > > Acked-

Re: [PATCH 02/11] x86/vPMU: avoid effectively open-coding xzalloc_flex_struct()

2021-04-08 Thread Andrew Cooper
On 08/04/2021 13:17, Jan Beulich wrote: > There is a difference in generated code: xzalloc_bytes() forces > SMP_CACHE_BYTES alignment. I think we not only don't need this here, but > actually don't want it. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper > > --- a/xen/arch/x86/cpu/vpmu_i

[PATCH 02/11] x86/vPMU: avoid effectively open-coding xzalloc_flex_struct()

2021-04-08 Thread Jan Beulich
There is a difference in generated code: xzalloc_bytes() forces SMP_CACHE_BYTES alignment. I think we not only don't need this here, but actually don't want it. Signed-off-by: Jan Beulich --- a/xen/arch/x86/cpu/vpmu_intel.c +++ b/xen/arch/x86/cpu/vpmu_intel.c @@ -461,10 +461,10 @@ static int cor