Re: [PATCH 03/11] null_blk: don't set the discard_alignment queue limit

2022-04-18 Thread Chaitanya Kulkarni
On 4/17/22 21:53, Christoph Hellwig wrote: > The discard_alignment queue limit is named a bit misleading means the > offset into the block device at which the discard granularity starts. > Setting it to the discard granularity as done by null_blk is mostly > harmless but also useless. > > Signed-o

Re: [dm-devel] [PATCH 03/11] null_blk: don't set the discard_alignment queue limit

2022-04-18 Thread Damien Le Moal
On 4/18/22 13:53, Christoph Hellwig wrote: > The discard_alignment queue limit is named a bit misleading means the > offset into the block device at which the discard granularity starts. > Setting it to the discard granularity as done by null_blk is mostly > harmless but also useless. > > Signed-o

[PATCH 03/11] null_blk: don't set the discard_alignment queue limit

2022-04-17 Thread Christoph Hellwig
The discard_alignment queue limit is named a bit misleading means the offset into the block device at which the discard granularity starts. Setting it to the discard granularity as done by null_blk is mostly harmless but also useless. Signed-off-by: Christoph Hellwig --- drivers/block/null_blk/m