Re: [PATCH 1/1] xen/blkfront: fix comment for need_copy

2022-03-21 Thread Jens Axboe
On Thu, 17 Mar 2022 15:09:30 -0700, Dongli Zhang wrote: > The 'need_copy' is set when rq_data_dir(req) returns WRITE, in order to > copy the written data to persistent page. > > ".need_copy = rq_data_dir(req) && info->feature_persistent," > > Applied, thanks! [1/1] xen/blkfront: fix comment

Re: [PATCH 1/1] xen/blkfront: fix comment for need_copy

2022-03-21 Thread Juergen Gross
On 21.03.22 11:05, Roger Pau Monné wrote: On Thu, Mar 17, 2022 at 03:09:30PM -0700, Dongli Zhang wrote: The 'need_copy' is set when rq_data_dir(req) returns WRITE, in order to copy the written data to persistent page. ".need_copy = rq_data_dir(req) && info->feature_persistent," I would also

Re: [PATCH 1/1] xen/blkfront: fix comment for need_copy

2022-03-21 Thread Roger Pau Monné
On Thu, Mar 17, 2022 at 03:09:30PM -0700, Dongli Zhang wrote: > The 'need_copy' is set when rq_data_dir(req) returns WRITE, in order to > copy the written data to persistent page. > > ".need_copy = rq_data_dir(req) && info->feature_persistent," I would also add: Fixes: c004a6fe0c40

Re: [PATCH 1/1] xen/blkfront: fix comment for need_copy

2022-03-17 Thread Chaitanya Kulkarni
On 3/17/22 3:09 PM, Dongli Zhang wrote: > The 'need_copy' is set when rq_data_dir(req) returns WRITE, in order to > copy the written data to persistent page. > > ".need_copy = rq_data_dir(req) && info->feature_persistent," > > Signed-off-by: Dongli Zhang > --- Looks good. Reviewed-by:

[PATCH 1/1] xen/blkfront: fix comment for need_copy

2022-03-17 Thread Dongli Zhang
The 'need_copy' is set when rq_data_dir(req) returns WRITE, in order to copy the written data to persistent page. ".need_copy = rq_data_dir(req) && info->feature_persistent," Signed-off-by: Dongli Zhang --- drivers/block/xen-blkfront.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)