Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-12-02 Thread Oleksandr
On 02.12.21 11:09, Julien Grall wrote: Hi Julien, Jan Hi Jan, On 13/09/2021 07:41, Jan Beulich wrote: Without holding appropriate locks, attempting to remove a prior mapping of the underlying page is pointless, as the same (or another) mapping could be re-established by a parallel request o

Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-12-02 Thread Julien Grall
Hi Jan, On 02/12/2021 10:12, Jan Beulich wrote: On 02.12.2021 10:09, Julien Grall wrote: Hi Jan, On 13/09/2021 07:41, Jan Beulich wrote: Without holding appropriate locks, attempting to remove a prior mapping of the underlying page is pointless, as the same (or another) mapping could be re-es

Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-12-02 Thread Jan Beulich
On 02.12.2021 10:09, Julien Grall wrote: > Hi Jan, > > On 13/09/2021 07:41, Jan Beulich wrote: >> Without holding appropriate locks, attempting to remove a prior mapping >> of the underlying page is pointless, as the same (or another) mapping >> could be re-established by a parallel request on ano

Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-12-02 Thread Julien Grall
Hi Jan, On 13/09/2021 07:41, Jan Beulich wrote: Without holding appropriate locks, attempting to remove a prior mapping of the underlying page is pointless, as the same (or another) mapping could be re-established by a parallel request on another vCPU. Move the code to Arm's gnttab_set_frame_gfn

Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-12-01 Thread Julien Grall
Hi Jan, On 26/11/2021 08:07, Jan Beulich wrote: On 25.11.2021 17:37, Julien Grall wrote: On 13/09/2021 07:41, Jan Beulich wrote: Without holding appropriate locks, attempting to remove a prior mapping of the underlying page is pointless, as the same (or another) mapping could be re-established

Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-11-26 Thread Jan Beulich
On 25.11.2021 17:37, Julien Grall wrote: > On 13/09/2021 07:41, Jan Beulich wrote: >> Without holding appropriate locks, attempting to remove a prior mapping >> of the underlying page is pointless, as the same (or another) mapping >> could be re-established by a parallel request on another vCPU. Mo

Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-11-25 Thread Julien Grall
Hi Jan, Sorry for the delay. I was waiting for XSA-387 to go out before answering. On 13/09/2021 07:41, Jan Beulich wrote: Without holding appropriate locks, attempting to remove a prior mapping of the underlying page is pointless, as the same (or another) mapping could be re-established by a p

Ping: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-09-28 Thread Jan Beulich
On 22.09.2021 12:00, Roger Pau Monné wrote: > On Wed, Sep 22, 2021 at 11:42:30AM +0200, Jan Beulich wrote: >> On 22.09.2021 11:26, Roger Pau Monné wrote: >>> On Tue, Sep 21, 2021 at 12:12:05PM +0200, Jan Beulich wrote: On 21.09.2021 10:32, Roger Pau Monné wrote: > On Mon, Sep 20, 2021 at 0

Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-09-23 Thread Julien Grall
Hi Jan, On 22/09/2021 15:47, Jan Beulich wrote: On 22.09.2021 12:28, Julien Grall wrote: Hi, On 22/09/2021 14:42, Jan Beulich wrote: On 22.09.2021 11:26, Roger Pau Monné wrote: On Tue, Sep 21, 2021 at 12:12:05PM +0200, Jan Beulich wrote: On 21.09.2021 10:32, Roger Pau Monné wrote: On Mon,

Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-09-22 Thread Jan Beulich
On 22.09.2021 12:28, Julien Grall wrote: > Hi, > > On 22/09/2021 14:42, Jan Beulich wrote: >> On 22.09.2021 11:26, Roger Pau Monné wrote: >>> On Tue, Sep 21, 2021 at 12:12:05PM +0200, Jan Beulich wrote: On 21.09.2021 10:32, Roger Pau Monné wrote: > On Mon, Sep 20, 2021 at 05:27:17PM +0200

Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-09-22 Thread Julien Grall
Hi, On 22/09/2021 14:42, Jan Beulich wrote: On 22.09.2021 11:26, Roger Pau Monné wrote: On Tue, Sep 21, 2021 at 12:12:05PM +0200, Jan Beulich wrote: On 21.09.2021 10:32, Roger Pau Monné wrote: On Mon, Sep 20, 2021 at 05:27:17PM +0200, Jan Beulich wrote: On 20.09.2021 12:20, Roger Pau Monné w

Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-09-22 Thread Roger Pau Monné
On Wed, Sep 22, 2021 at 11:42:30AM +0200, Jan Beulich wrote: > On 22.09.2021 11:26, Roger Pau Monné wrote: > > On Tue, Sep 21, 2021 at 12:12:05PM +0200, Jan Beulich wrote: > >> On 21.09.2021 10:32, Roger Pau Monné wrote: > >>> On Mon, Sep 20, 2021 at 05:27:17PM +0200, Jan Beulich wrote: > On 2

Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-09-22 Thread Jan Beulich
On 22.09.2021 11:26, Roger Pau Monné wrote: > On Tue, Sep 21, 2021 at 12:12:05PM +0200, Jan Beulich wrote: >> On 21.09.2021 10:32, Roger Pau Monné wrote: >>> On Mon, Sep 20, 2021 at 05:27:17PM +0200, Jan Beulich wrote: On 20.09.2021 12:20, Roger Pau Monné wrote: > On Mon, Sep 13, 2021 at 0

Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-09-22 Thread Roger Pau Monné
On Tue, Sep 21, 2021 at 12:12:05PM +0200, Jan Beulich wrote: > On 21.09.2021 10:32, Roger Pau Monné wrote: > > On Mon, Sep 20, 2021 at 05:27:17PM +0200, Jan Beulich wrote: > >> On 20.09.2021 12:20, Roger Pau Monné wrote: > >>> On Mon, Sep 13, 2021 at 08:41:47AM +0200, Jan Beulich wrote: > ---

Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-09-21 Thread Jan Beulich
On 21.09.2021 10:32, Roger Pau Monné wrote: > On Mon, Sep 20, 2021 at 05:27:17PM +0200, Jan Beulich wrote: >> On 20.09.2021 12:20, Roger Pau Monné wrote: >>> On Mon, Sep 13, 2021 at 08:41:47AM +0200, Jan Beulich wrote: --- a/xen/include/asm-arm/grant_table.h +++ b/xen/include/asm-arm/gran

Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-09-21 Thread Roger Pau Monné
On Mon, Sep 20, 2021 at 05:27:17PM +0200, Jan Beulich wrote: > On 20.09.2021 12:20, Roger Pau Monné wrote: > > On Mon, Sep 13, 2021 at 08:41:47AM +0200, Jan Beulich wrote: > >> --- a/xen/include/asm-arm/grant_table.h > >> +++ b/xen/include/asm-arm/grant_table.h > >> +if ( gfn_eq(ogfn, INVAL

Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-09-20 Thread Jan Beulich
On 20.09.2021 12:20, Roger Pau Monné wrote: > On Mon, Sep 13, 2021 at 08:41:47AM +0200, Jan Beulich wrote: >> --- a/xen/include/asm-arm/grant_table.h >> +++ b/xen/include/asm-arm/grant_table.h >> @@ -71,11 +71,17 @@ int replace_grant_host_mapping(unsigned >> XFREE((gt)->arch.status_gfn);

Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-09-20 Thread Roger Pau Monné
On Mon, Sep 13, 2021 at 08:41:47AM +0200, Jan Beulich wrote: > Without holding appropriate locks, attempting to remove a prior mapping > of the underlying page is pointless, as the same (or another) mapping > could be re-established by a parallel request on another vCPU. Move the > code to Arm's gn

[PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-09-12 Thread Jan Beulich
Without holding appropriate locks, attempting to remove a prior mapping of the underlying page is pointless, as the same (or another) mapping could be re-established by a parallel request on another vCPU. Move the code to Arm's gnttab_set_frame_gfn(). Of course this new placement doesn't improve th