Re: [PATCH 1/2] tools/migration: Fix iovec handling in send_checkpoint_dirty_pfn_list()

2021-07-06 Thread Olaf Hering
Am Tue, 6 Jul 2021 12:23:31 +0100 schrieb Andrew Cooper : > We shouldn't be using two struct iovec's to write half of 'rec' each, and > there is no need to malloc() for two struct iovec's at all. > > Simplify down to just two - one covering the whole of 'rec', and one covering > the pfns array.

Re: [PATCH 1/2] tools/migration: Fix iovec handling in send_checkpoint_dirty_pfn_list()

2021-07-06 Thread Jan Beulich
On 06.07.2021 13:23, Andrew Cooper wrote: > We shouldn't be using two struct iovec's to write half of 'rec' each, and > there is no need to malloc() for two struct iovec's at all. I was indeed wondering about all of these while also touching the function. But I was guessing that there might be a d

[PATCH 1/2] tools/migration: Fix iovec handling in send_checkpoint_dirty_pfn_list()

2021-07-06 Thread Andrew Cooper
We shouldn't be using two struct iovec's to write half of 'rec' each, and there is no need to malloc() for two struct iovec's at all. Simplify down to just two - one covering the whole of 'rec', and one covering the pfns array. No functional change. Signed-off-by: Andrew Cooper --- CC: Ian Jack