Re: [PATCH 1/2] x86/vPIT: re-order functions

2023-06-06 Thread Roger Pau Monné
On Thu, Jun 01, 2023 at 04:06:53PM +0200, Jan Beulich wrote: > On 01.06.2023 13:50, Roger Pau Monné wrote: > > On Thu, Jun 01, 2023 at 11:56:12AM +0200, Jan Beulich wrote: > >> On 01.06.2023 11:17, Roger Pau Monné wrote: > >>> On Tue, May 30, 2023 at 05:30:02PM +0200, Jan Beulich wrote: > To

Re: [PATCH 1/2] x86/vPIT: re-order functions

2023-06-01 Thread Jan Beulich
On 01.06.2023 13:50, Roger Pau Monné wrote: > On Thu, Jun 01, 2023 at 11:56:12AM +0200, Jan Beulich wrote: >> On 01.06.2023 11:17, Roger Pau Monné wrote: >>> On Tue, May 30, 2023 at 05:30:02PM +0200, Jan Beulich wrote: To avoid the need for a forward declaration of pit_load_count() in a

Re: [PATCH 1/2] x86/vPIT: re-order functions

2023-06-01 Thread Roger Pau Monné
On Thu, Jun 01, 2023 at 11:56:12AM +0200, Jan Beulich wrote: > On 01.06.2023 11:17, Roger Pau Monné wrote: > > On Tue, May 30, 2023 at 05:30:02PM +0200, Jan Beulich wrote: > >> To avoid the need for a forward declaration of pit_load_count() in a > >> subsequent change, move it earlier in the file

Re: [PATCH 1/2] x86/vPIT: re-order functions

2023-06-01 Thread Jan Beulich
On 01.06.2023 11:17, Roger Pau Monné wrote: > On Tue, May 30, 2023 at 05:30:02PM +0200, Jan Beulich wrote: >> To avoid the need for a forward declaration of pit_load_count() in a >> subsequent change, move it earlier in the file (along with its helper >> callback). >> >> Signed-off-by: Jan Beulich

Re: [PATCH 1/2] x86/vPIT: re-order functions

2023-06-01 Thread Roger Pau Monné
On Tue, May 30, 2023 at 05:30:02PM +0200, Jan Beulich wrote: > To avoid the need for a forward declaration of pit_load_count() in a > subsequent change, move it earlier in the file (along with its helper > callback). > > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Just a couple of

[PATCH 1/2] x86/vPIT: re-order functions

2023-05-30 Thread Jan Beulich
To avoid the need for a forward declaration of pit_load_count() in a subsequent change, move it earlier in the file (along with its helper callback). Signed-off-by: Jan Beulich --- a/xen/arch/x86/emul-i8254.c +++ b/xen/arch/x86/emul-i8254.c @@ -87,6 +87,57 @@ static int pit_get_count(PITState