Re: [PATCH 1/3] tools/libacpi: Use 64-byte alignment for FACS [and 1 more messages]

2021-09-13 Thread Jan Beulich
On 10.09.2021 16:50, Ian Jackson wrote: > Andrew Cooper writes ("Re: [PATCH 1/3] tools/libacpi: Use 64-byte alignment > for FACS"): >> The current code is clearly wrong, but happens to work correctly in >> hvmloader because FACS is the first table written and it starts

Re: [PATCH 1/3] tools/libacpi: Use 64-byte alignment for FACS [and 1 more messages]

2021-09-10 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH 1/3] tools/libacpi: Use 64-byte alignment for FACS"): > The current code is clearly wrong, but happens to work correctly in > hvmloader because FACS is the first table written and it starts on a > page boundary.  The logic does not work c

Re: [PATCH 1/3] tools/libacpi: Use 64-byte alignment for FACS

2021-09-10 Thread Jan Beulich
On 09.09.2021 18:34, Kevin Stefanov wrote: > The spec requires 64-byte alignment, not 16. > > Signed-off-by: Kevin Stefanov Reviewed-by: Jan Beulich

Re: [PATCH 1/3] tools/libacpi: Use 64-byte alignment for FACS

2021-09-09 Thread Andrew Cooper
On 09/09/2021 17:34, Kevin Stefanov wrote: > The spec requires 64-byte alignment, not 16. > > Signed-off-by: Kevin Stefanov > --- > CC: Jan Beulich > CC: Andrew Cooper > > Note: This does not fix the FACS alignment inside guests yet. See next > patch. The history here is complex. c/s 938cee9d4

[PATCH 1/3] tools/libacpi: Use 64-byte alignment for FACS

2021-09-09 Thread Kevin Stefanov
The spec requires 64-byte alignment, not 16. Signed-off-by: Kevin Stefanov --- CC: Jan Beulich CC: Andrew Cooper Note: This does not fix the FACS alignment inside guests yet. See next patch. --- tools/libacpi/build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/li