Re: [PATCH 1/3] x86/S3: Use percpu_traps_init() rather than opencoding SYSCALL/SYSENTER restoration

2020-04-23 Thread Jan Beulich
On 23.04.2020 20:24, Andrew Cooper wrote: > On 21/04/2020 08:24, Jan Beulich wrote: >> On 20.04.2020 16:59, Andrew Cooper wrote: >>> @@ -46,24 +36,13 @@ void restore_rest_processor_state(void) >>> /* Restore full CR4 (inc MCE) now that the IDT is in place. */ >>> write_cr4(mmu_cr4_feature

Re: [PATCH 1/3] x86/S3: Use percpu_traps_init() rather than opencoding SYSCALL/SYSENTER restoration

2020-04-23 Thread Andrew Cooper
On 21/04/2020 08:24, Jan Beulich wrote: > On 20.04.2020 16:59, Andrew Cooper wrote: >> @@ -46,24 +36,13 @@ void restore_rest_processor_state(void) >> /* Restore full CR4 (inc MCE) now that the IDT is in place. */ >> write_cr4(mmu_cr4_features); >> >> -/* Recover syscall MSRs */ >> -

Re: [PATCH 1/3] x86/S3: Use percpu_traps_init() rather than opencoding SYSCALL/SYSENTER restoration

2020-04-21 Thread Jan Beulich
On 20.04.2020 16:59, Andrew Cooper wrote: > @@ -46,24 +36,13 @@ void restore_rest_processor_state(void) > /* Restore full CR4 (inc MCE) now that the IDT is in place. */ > write_cr4(mmu_cr4_features); > > -/* Recover syscall MSRs */ > -wrmsrl(MSR_LSTAR, saved_lstar); > -wrmsr

[PATCH 1/3] x86/S3: Use percpu_traps_init() rather than opencoding SYSCALL/SYSENTER restoration

2020-04-20 Thread Andrew Cooper
This make the S3 BSP path consistent with AP paths, and reduces the amount of state needing stashing specially. Also, it takes care of re-setting up Xen's LBR configuration if requested, which was missing previously. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Mo