RE: [PATCH 1/3] xen/arm: vpl011: Fix misleading comments

2023-04-11 Thread Henry Wang
Hi Michal, > -Original Message- > Subject: [PATCH 1/3] xen/arm: vpl011: Fix misleading comments > > In both vpl011_read_data() and vpl011_read_data_xen(), there is a comment > stating that the guest is expected to read the DR register only if the > TXFE bit of FR r

Re: [PATCH 1/3] xen/arm: vpl011: Fix misleading comments

2023-04-07 Thread Stefano Stabellini
On Thu, 6 Apr 2023, Ayan Kumar Halder wrote: > On 05/04/2023 12:17, Michal Orzel wrote: > > In both vpl011_read_data() and vpl011_read_data_xen(), there is a comment > > stating that the guest is expected to read the DR register only if the > > TXFE bit of FR register is not set. This is obviously

Re: [PATCH 1/3] xen/arm: vpl011: Fix misleading comments

2023-04-06 Thread Ayan Kumar Halder
On 05/04/2023 12:17, Michal Orzel wrote: In both vpl011_read_data() and vpl011_read_data_xen(), there is a comment stating that the guest is expected to read the DR register only if the TXFE bit of FR register is not set. This is obviously logically wrong and it should be RXFE (i.e. RX FIFO emp

[PATCH 1/3] xen/arm: vpl011: Fix misleading comments

2023-04-05 Thread Michal Orzel
In both vpl011_read_data() and vpl011_read_data_xen(), there is a comment stating that the guest is expected to read the DR register only if the TXFE bit of FR register is not set. This is obviously logically wrong and it should be RXFE (i.e. RX FIFO empty bit set -> nothing to read). Signed-off-b