Re: [PATCH 1/5] x86/p2m: paging_write_p2m_entry() is a private function

2020-11-10 Thread Jan Beulich
On 10.11.2020 11:27, Roger Pau Monné wrote: > On Wed, Oct 28, 2020 at 10:22:04AM +0100, Jan Beulich wrote: >> As it gets installed by p2m_pt_init(), it doesn't need to live in >> paging.c. The function working in terms of l1_pgentry_t even further >> indicates its non-paging-generic nature. Move

Re: [PATCH 1/5] x86/p2m: paging_write_p2m_entry() is a private function

2020-11-10 Thread Roger Pau Monné
On Wed, Oct 28, 2020 at 10:22:04AM +0100, Jan Beulich wrote: > As it gets installed by p2m_pt_init(), it doesn't need to live in > paging.c. The function working in terms of l1_pgentry_t even further > indicates its non-paging-generic nature. Move it and drop its > paging_ prefix, not adding any

[PATCH 1/5] x86/p2m: paging_write_p2m_entry() is a private function

2020-10-28 Thread Jan Beulich
As it gets installed by p2m_pt_init(), it doesn't need to live in paging.c. The function working in terms of l1_pgentry_t even further indicates its non-paging-generic nature. Move it and drop its paging_ prefix, not adding any new one now that it's static. This then also makes more obvious that