Re: [PATCH 1/7] fs: remove __sync_filesystem

2021-10-18 Thread Chaitanya Kulkarni
On 10/18/2021 11:25 PM, Christoph Hellwig wrote: > There is no clear benefit in having this helper vs just open coding it. > > Signed-off-by: Christoph Hellwig Especially if there is only one caller. Looks good. Reviewed-by: Chaitanya Kulkarni

[PATCH 1/7] fs: remove __sync_filesystem

2021-10-18 Thread Christoph Hellwig
There is no clear benefit in having this helper vs just open coding it. Signed-off-by: Christoph Hellwig --- fs/sync.c | 38 +- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/fs/sync.c b/fs/sync.c index 1373a610dc784..0d6cdc507cb98 100644 ---