Re: [PATCH 2/3] x86/entry: Make #PF/NMI more amenable to livepatching

2024-01-22 Thread Andrew Cooper
On 22/01/2024 6:17 pm, Andrew Cooper wrote: > It is bad form to have inter-function fallthrough. It only functions right > now because alignment padding bytes are NOPs. > > However, it also interferes with livepatching binary diffs, because the > implicit grouping of the two functions isn't

[PATCH 2/3] x86/entry: Make #PF/NMI more amenable to livepatching

2024-01-22 Thread Andrew Cooper
It is bad form to have inter-function fallthrough. It only functions right now because alignment padding bytes are NOPs. However, it also interferes with livepatching binary diffs, because the implicit grouping of the two functions isn't expressed in the ELF metadata. Signed-off-by: Andrew