Re: [PATCH 2/3] x86/irq: don't disable domain MSI IRQ on force unbind

2021-01-27 Thread Jan Beulich
On 26.01.2021 17:21, Roger Pau Monné wrote: > On Tue, Jan 26, 2021 at 03:52:54PM +0100, Jan Beulich wrote: >> On 26.01.2021 12:06, Roger Pau Monne wrote: >>> When force unbinding a MSI the used IRQ would get added to the domain >>> irq-pirq tree as -irq -pirq, >> >> I think it's -pirq at index irq,

Re: [PATCH 2/3] x86/irq: don't disable domain MSI IRQ on force unbind

2021-01-26 Thread Roger Pau Monné
On Tue, Jan 26, 2021 at 03:52:54PM +0100, Jan Beulich wrote: > On 26.01.2021 12:06, Roger Pau Monne wrote: > > When force unbinding a MSI the used IRQ would get added to the domain > > irq-pirq tree as -irq -pirq, > > I think it's -pirq at index irq, i.e. I don't think IRQ gets > negated as far as

Re: [PATCH 2/3] x86/irq: don't disable domain MSI IRQ on force unbind

2021-01-26 Thread Jan Beulich
On 26.01.2021 12:06, Roger Pau Monne wrote: > When force unbinding a MSI the used IRQ would get added to the domain > irq-pirq tree as -irq -pirq, I think it's -pirq at index irq, i.e. I don't think IRQ gets negated as far as the radix tree goes. info->arch.irq gets a negative value stored, yes.

[PATCH 2/3] x86/irq: don't disable domain MSI IRQ on force unbind

2021-01-26 Thread Roger Pau Monne
When force unbinding a MSI the used IRQ would get added to the domain irq-pirq tree as -irq -pirq, thus preventing the same IRQ to be used by the domain. Doing so for MSI allocated IRQs prevents the same IRQ to be used for any other device, since MSI IRQs are allocated and deallocated on demand unl