The return value was only used for WARN()s or BUG()s so it has no
functional purpose. Simplify the code by removing it.
The meaning of the return value and the purpose of the various WARNs()
and BUGs() is rather unclear. The only failure path (where an MSI-X
vector needs to be masked but the MSI-X
On 10.11.2022 17:59, David Vrabel wrote:
> The return value was only used for WARN()s or BUG()s so it has no
> functional purpose. Simplify the code by removing it.
>
> The meaning of the return value and the purpose of the various WARNs()
> and BUGs() is rather unclear. The only failure path (whe
On 11/11/2022 09:44, Jan Beulich wrote:
The idea of the WARN() / BUG_ON() is to
- not leave failed unmasking unrecorded,
- not continue after failure to mask an entry.
Then lets make msi_set_mask_bit() unable to fail with something like
this (untested) patch. Would this be acceptable?
Da
On 11.11.2022 15:41, David Vrabel wrote:
> On 11/11/2022 09:44, Jan Beulich wrote:
>>
>> The idea of the WARN() / BUG_ON() is to
>> - not leave failed unmasking unrecorded,
>> - not continue after failure to mask an entry.
>
> Then lets make msi_set_mask_bit() unable to fail with something like
>
