Re: [PATCH 2/3] xen: Export dbgp functions when CONFIG_XEN_DOM0 is enabled

2021-05-12 Thread Boris Ostrovsky
On 5/12/21 10:58 AM, Connor Davis wrote: > On May 12, 21, Boris Ostrovsky wrote: >> Unrelated to your patch but since you are fixing things around that file --- >> should we return -EPERM in xen_dbgp_op() when !xen_initial_domain()? > Yeah looks like it. That would make patch 3 simpler too. > Do

Re: [PATCH 2/3] xen: Export dbgp functions when CONFIG_XEN_DOM0 is enabled

2021-05-12 Thread Connor Davis
On May 12, 21, Juergen Gross wrote: > On 12.05.21 02:18, Connor Davis wrote: > > Export xen_dbgp_reset_prep and xen_dbgp_external_startup > > when CONFIG_XEN_DOM0 is defined. This allows use of these symbols > > even if CONFIG_EARLY_PRINK_DBGP is defined. > > > > Signed-off-by: Connor Davis > > Ac

Re: [PATCH 2/3] xen: Export dbgp functions when CONFIG_XEN_DOM0 is enabled

2021-05-12 Thread Connor Davis
On May 12, 21, Boris Ostrovsky wrote: > > On 5/11/21 8:18 PM, Connor Davis wrote: > > Export xen_dbgp_reset_prep and xen_dbgp_external_startup > > when CONFIG_XEN_DOM0 is defined. This allows use of these symbols > > even if CONFIG_EARLY_PRINK_DBGP is defined. > > > > Signed-off-by: Connor Davis >

Re: [PATCH 2/3] xen: Export dbgp functions when CONFIG_XEN_DOM0 is enabled

2021-05-12 Thread Boris Ostrovsky
On 5/11/21 8:18 PM, Connor Davis wrote: > Export xen_dbgp_reset_prep and xen_dbgp_external_startup > when CONFIG_XEN_DOM0 is defined. This allows use of these symbols > even if CONFIG_EARLY_PRINK_DBGP is defined. > > Signed-off-by: Connor Davis > --- > drivers/xen/dbgp.c | 2 +- Unrelated to y

Re: [PATCH 2/3] xen: Export dbgp functions when CONFIG_XEN_DOM0 is enabled

2021-05-11 Thread Juergen Gross
On 12.05.21 02:18, Connor Davis wrote: Export xen_dbgp_reset_prep and xen_dbgp_external_startup when CONFIG_XEN_DOM0 is defined. This allows use of these symbols even if CONFIG_EARLY_PRINK_DBGP is defined. Signed-off-by: Connor Davis Acked-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628B

[PATCH 2/3] xen: Export dbgp functions when CONFIG_XEN_DOM0 is enabled

2021-05-11 Thread Connor Davis
Export xen_dbgp_reset_prep and xen_dbgp_external_startup when CONFIG_XEN_DOM0 is defined. This allows use of these symbols even if CONFIG_EARLY_PRINK_DBGP is defined. Signed-off-by: Connor Davis --- drivers/xen/dbgp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xe