[PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

2020-12-15 Thread Jan Beulich
This is together with its only caller, xenmem_add_to_physmap_one(). Move the latter next to p2m_add_foreign(), allowing this one to become static at the same time. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -118,7 +118,6 @@ #include #include #include -#in

Re: [PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

2020-12-17 Thread Andrew Cooper
On 15/12/2020 16:26, Jan Beulich wrote: > This is together with its only caller, xenmem_add_to_physmap_one(). I can't parse this sentence.  Perhaps "... as is it's only caller," as a follow-on from the subject sentence. > Move > the latter next to p2m_add_foreign(), allowing this one to become s

Re: [PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

2020-12-18 Thread Jan Beulich
On 17.12.2020 20:18, Andrew Cooper wrote: > On 15/12/2020 16:26, Jan Beulich wrote: >> This is together with its only caller, xenmem_add_to_physmap_one(). > > I can't parse this sentence.  Perhaps "... as is it's only caller," as a > follow-on from the subject sentence. Yeah, changed along these

Re: [PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

2020-12-21 Thread Jan Beulich
On 17.12.2020 20:18, Andrew Cooper wrote: > On 15/12/2020 16:26, Jan Beulich wrote: >> This is together with its only caller, xenmem_add_to_physmap_one(). > > I can't parse this sentence.  Perhaps "... as is it's only caller," as a > follow-on from the subject sentence. > >> Move >> the latter n

Re: [PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

2020-12-22 Thread Andrew Cooper
On 21/12/2020 08:10, Jan Beulich wrote: > On 17.12.2020 20:18, Andrew Cooper wrote: >> On 15/12/2020 16:26, Jan Beulich wrote: >>> This is together with its only caller, xenmem_add_to_physmap_one(). >> I can't parse this sentence.  Perhaps "... as is it's only caller," as a >> follow-on from the su

Re: [PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

2021-01-04 Thread Oleksandr Tyshchenko
Hello all. [Sorry for the possible format issues] On Tue, Dec 22, 2020 at 12:41 PM Andrew Cooper wrote: > On 21/12/2020 08:10, Jan Beulich wrote: > > On 17.12.2020 20:18, Andrew Cooper wrote: > >> On 15/12/2020 16:26, Jan Beulich wrote: > >>> This is together with its only caller, xenmem_add_to

Re: [PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

2021-01-05 Thread Jan Beulich
On 04.01.2021 17:57, Oleksandr Tyshchenko wrote: > Hello all. > > [Sorry for the possible format issues] > > On Tue, Dec 22, 2020 at 12:41 PM Andrew Cooper > wrote: > >> On 21/12/2020 08:10, Jan Beulich wrote: >>> On 17.12.2020 20:18, Andrew Cooper wrote: On 15/12/2020 16:26, Jan Beulich w

Re: [PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

2021-01-08 Thread Oleksandr
On 05.01.21 10:48, Jan Beulich wrote: Hi Jan On 04.01.2021 17:57, Oleksandr Tyshchenko wrote: Hello all. [Sorry for the possible format issues] On Tue, Dec 22, 2020 at 12:41 PM Andrew Cooper wrote: On 21/12/2020 08:10, Jan Beulich wrote: On 17.12.2020 20:18, Andrew Cooper wrote: On 1

Re: [PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

2021-01-08 Thread Jan Beulich
On 08.01.2021 17:38, Oleksandr wrote: > On 05.01.21 10:48, Jan Beulich wrote: >> On 04.01.2021 17:57, Oleksandr Tyshchenko wrote: >>> Hello all. >>> >>> [Sorry for the possible format issues] >>> >>> On Tue, Dec 22, 2020 at 12:41 PM Andrew Cooper >>> wrote: >>> On 21/12/2020 08:10, Jan Beulic

Re: [PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

2021-01-08 Thread Oleksandr
On 08.01.21 19:01, Jan Beulich wrote: Hi Jan On 08.01.2021 17:38, Oleksandr wrote: On 05.01.21 10:48, Jan Beulich wrote: On 04.01.2021 17:57, Oleksandr Tyshchenko wrote: Hello all. [Sorry for the possible format issues] On Tue, Dec 22, 2020 at 12:41 PM Andrew Cooper wrote: On 21/12/20

Re: [PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

2021-01-10 Thread Jan Beulich
On 08.01.2021 18:37, Oleksandr wrote: > > On 08.01.21 19:01, Jan Beulich wrote: > > Hi Jan > >> On 08.01.2021 17:38, Oleksandr wrote: >>> On 05.01.21 10:48, Jan Beulich wrote: On 04.01.2021 17:57, Oleksandr Tyshchenko wrote: > Hello all. > > [Sorry for the possible format issues

Re: [PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

2021-01-11 Thread Oleksandr
On 11.01.21 09:41, Jan Beulich wrote: Hi Jan On 08.01.2021 18:37, Oleksandr wrote: On 08.01.21 19:01, Jan Beulich wrote: Hi Jan On 08.01.2021 17:38, Oleksandr wrote: On 05.01.21 10:48, Jan Beulich wrote: On 04.01.2021 17:57, Oleksandr Tyshchenko wrote: Hello all. [Sorry for the possib

Re: [PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

2021-01-12 Thread Jan Beulich
On 11.01.2021 09:23, Oleksandr wrote: > On 11.01.21 09:41, Jan Beulich wrote: >> If you could also provide your exact .config, I could see whether I >> can repro here with some of the gcc5 versions I have laying around. > > Please see attached Builds perfectly fine with 5.4.0 here. Jan

Re: [PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

2021-01-13 Thread Oleksandr
On 12.01.21 13:58, Jan Beulich wrote: Hi Jan. On 11.01.2021 09:23, Oleksandr wrote: On 11.01.21 09:41, Jan Beulich wrote: If you could also provide your exact .config, I could see whether I can repro here with some of the gcc5 versions I have laying around. Please see attached Builds perf

Re: [PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

2021-01-23 Thread Julien Grall
Hi Jan & Oleksandr, On 13/01/2021 15:06, Oleksandr wrote: On 12.01.21 13:58, Jan Beulich wrote: Hi Jan. On 11.01.2021 09:23, Oleksandr wrote: On 11.01.21 09:41, Jan Beulich wrote: If you could also provide your exact .config, I could see whether I can repro here with some of the gcc5 versi

Re: [PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

2021-01-25 Thread Jan Beulich
On 23.01.2021 14:22, Julien Grall wrote: > On 13/01/2021 15:06, Oleksandr wrote: >> On 12.01.21 13:58, Jan Beulich wrote: >>> On 11.01.2021 09:23, Oleksandr wrote: On 11.01.21 09:41, Jan Beulich wrote: > If you could also provide your exact .config, I could see whether I > can repro he

Re: [PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

2021-01-25 Thread Jan Beulich
On 23.01.2021 14:22, Julien Grall wrote: > On 13/01/2021 15:06, Oleksandr wrote: >> On 12.01.21 13:58, Jan Beulich wrote: >>> On 11.01.2021 09:23, Oleksandr wrote: On 11.01.21 09:41, Jan Beulich wrote: > If you could also provide your exact .config, I could see whether I > can repro he