Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD

2022-04-14 Thread Chaitanya Kulkarni
On 4/14/22 21:52, Christoph Hellwig wrote: > Just use a non-zero max_discard_sectors as an indicator for discard > support, similar to what is done for write zeroes. > > The only places where needs special attention is the RAID5 driver, > which must clear discard support for security reasons by

[PATCH 24/27] block: remove QUEUE_FLAG_DISCARD

2022-04-14 Thread Christoph Hellwig
Just use a non-zero max_discard_sectors as an indicator for discard support, similar to what is done for write zeroes. The only places where needs special attention is the RAID5 driver, which must clear discard support for security reasons by default, even if the default stacking rules would

Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD

2022-04-11 Thread David Sterba
On Sat, Apr 09, 2022 at 06:50:40AM +0200, Christoph Hellwig wrote: > Just use a non-zero max_discard_sectors as an indicator for discard > support, similar to what is done for write zeroes. > > The only places where needs special attention is the RAID5 driver, > which must clear discard support

Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD

2022-04-11 Thread Keith Busch
On Sat, Apr 09, 2022 at 06:50:40AM +0200, Christoph Hellwig wrote: > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index efb85c6d8e2d5..7e07dd69262a7 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -1607,10 +1607,8 @@ static void

Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD

2022-04-11 Thread Jan Höppner
On 09/04/2022 06:50, Christoph Hellwig wrote: > Just use a non-zero max_discard_sectors as an indicator for discard > support, similar to what is done for write zeroes. > > The only places where needs special attention is the RAID5 driver, > which must clear discard support for security reasons

Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD

2022-04-10 Thread Christoph Hellwig
On Sat, Apr 09, 2022 at 10:15:33AM +0200, Christoph Böhmwalder wrote: > On 09.04.22 06:50, Christoph Hellwig wrote: >> Just use a non-zero max_discard_sectors as an indicator for discard >> support, similar to what is done for write zeroes. >> >> The only places where needs special attention is

Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD

2022-04-09 Thread Christoph Böhmwalder
On 09.04.22 06:50, Christoph Hellwig wrote: Just use a non-zero max_discard_sectors as an indicator for discard support, similar to what is done for write zeroes. The only places where needs special attention is the RAID5 driver, which must clear discard support for security reasons by default,

[PATCH 24/27] block: remove QUEUE_FLAG_DISCARD

2022-04-08 Thread Christoph Hellwig
Just use a non-zero max_discard_sectors as an indicator for discard support, similar to what is done for write zeroes. The only places where needs special attention is the RAID5 driver, which must clear discard support for security reasons by default, even if the default stacking rules would