Re: [PATCH 3/3] x86/ucode: Remove the collect_cpu_info() call from parse_blob()

2024-11-12 Thread Jan Beulich
On 12.11.2024 11:57, Andrew Cooper wrote: > On 12/11/2024 10:49 am, Jan Beulich wrote: >> On 12.11.2024 11:36, Andrew Cooper wrote: >>> On 07/11/2024 9:58 pm, Andrew Cooper wrote: On 07/11/2024 12:21 pm, Andrew Cooper wrote: > With the tangle of logic starting to come under control, it is

Re: [PATCH 3/3] x86/ucode: Remove the collect_cpu_info() call from parse_blob()

2024-11-12 Thread Andrew Cooper
On 12/11/2024 10:49 am, Jan Beulich wrote: > On 12.11.2024 11:36, Andrew Cooper wrote: >> On 07/11/2024 9:58 pm, Andrew Cooper wrote: >>> On 07/11/2024 12:21 pm, Andrew Cooper wrote: With the tangle of logic starting to come under control, it is now plain to see that parse_blob()'s side e

Re: [PATCH 3/3] x86/ucode: Remove the collect_cpu_info() call from parse_blob()

2024-11-12 Thread Jan Beulich
On 12.11.2024 11:36, Andrew Cooper wrote: > On 07/11/2024 9:58 pm, Andrew Cooper wrote: >> On 07/11/2024 12:21 pm, Andrew Cooper wrote: >>> With the tangle of logic starting to come under control, it is now plain to >>> see that parse_blob()'s side effect of re-gathering the signature/revision >>>

Re: [PATCH 3/3] x86/ucode: Remove the collect_cpu_info() call from parse_blob()

2024-11-12 Thread Andrew Cooper
On 07/11/2024 9:58 pm, Andrew Cooper wrote: > On 07/11/2024 12:21 pm, Andrew Cooper wrote: >> With the tangle of logic starting to come under control, it is now plain to >> see that parse_blob()'s side effect of re-gathering the signature/revision is >> pointless. >> >> The cpu_request_microcode()

Re: [PATCH 3/3] x86/ucode: Remove the collect_cpu_info() call from parse_blob()

2024-11-07 Thread Andrew Cooper
On 07/11/2024 12:21 pm, Andrew Cooper wrote: > With the tangle of logic starting to come under control, it is now plain to > see that parse_blob()'s side effect of re-gathering the signature/revision is > pointless. > > The cpu_request_microcode() hooks need the signature only. The BSP gathers > t

[PATCH 3/3] x86/ucode: Remove the collect_cpu_info() call from parse_blob()

2024-11-07 Thread Andrew Cooper
With the tangle of logic starting to come under control, it is now plain to see that parse_blob()'s side effect of re-gathering the signature/revision is pointless. The cpu_request_microcode() hooks need the signature only. The BSP gathers this in early_microcode_init(), the APs and S3 in microco