Re: [PATCH 3/6] x86/entry/64/compat: Fix Xen PV SYSENTER frame setup

2020-07-02 Thread Thomas Gleixner
Andy Lutomirski writes: > On Wed, Jul 1, 2020 at 8:42 AM Brian Gerst wrote: > > On Fri, Jun 26, 2020 at 1:30 PM Andy Lutomirski wrote: >> > >> > The SYSENTER frame setup was nonsense. It worked by accident >> > because the normal code into which the Xen asm jumped >> >

Re: [PATCH 3/6] x86/entry/64/compat: Fix Xen PV SYSENTER frame setup

2020-07-01 Thread Andy Lutomirski
On Wed, Jul 1, 2020 at 8:42 AM Brian Gerst wrote: > > On Fri, Jun 26, 2020 at 1:30 PM Andy Lutomirski wrote: > > > > The SYSENTER frame setup was nonsense. It worked by accident > > because the normal code into which the Xen asm jumped > > (entry_SYSENTER_32/compat) threw away SP without

Re: [PATCH 3/6] x86/entry/64/compat: Fix Xen PV SYSENTER frame setup

2020-07-01 Thread Brian Gerst
On Fri, Jun 26, 2020 at 1:30 PM Andy Lutomirski wrote: > > The SYSENTER frame setup was nonsense. It worked by accident > because the normal code into which the Xen asm jumped > (entry_SYSENTER_32/compat) threw away SP without touching the stack. > entry_SYSENTER_compat was recently modified

Re: [PATCH 3/6] x86/entry/64/compat: Fix Xen PV SYSENTER frame setup

2020-06-27 Thread Boris Ostrovsky
On 6/26/20 1:21 PM, Andy Lutomirski wrote: > The SYSENTER frame setup was nonsense. It worked by accident > because the normal code into which the Xen asm jumped > (entry_SYSENTER_32/compat) threw away SP without touching the stack. > entry_SYSENTER_compat was recently modified such that it

[PATCH 3/6] x86/entry/64/compat: Fix Xen PV SYSENTER frame setup

2020-06-26 Thread Andy Lutomirski
The SYSENTER frame setup was nonsense. It worked by accident because the normal code into which the Xen asm jumped (entry_SYSENTER_32/compat) threw away SP without touching the stack. entry_SYSENTER_compat was recently modified such that it relied on having a valid stack pointer, so now the Xen