Re: [PATCH 3/9] gnttab: fold recurring is_iomem_page()

On 06.09.2021 15:35, Julien Grall wrote: > On 26/08/2021 11:12, Jan Beulich wrote: >> In all cases call the function just once instead of up to four times, at > > extra NIT: It is more like two because there is a else in > gnttab_release_mappings() :) Well, I was viewing things from code gen pov

Re: [PATCH 3/9] gnttab: fold recurring is_iomem_page()

Hi Jan, On 26/08/2021 11:12, Jan Beulich wrote: In all cases call the function just once instead of up to four times, at extra NIT: It is more like two because there is a else in gnttab_release_mappings() :) the same time avoiding to store a dangling pointer in a local variable. Signed-of

[PATCH 3/9] gnttab: fold recurring is_iomem_page()

In all cases call the function just once instead of up to four times, at the same time avoiding to store a dangling pointer in a local variable. Signed-off-by: Jan Beulich --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -1587,11 +1587,11 @@ unmap_common_complete(struct gnttab_un