Re: [PATCH 4/4] livepatch: differentiate between old and new build systems

2022-03-21 Thread Roger Pau Monné
On Fri, Mar 11, 2022 at 09:33:15AM +0100, Roger Pau Monné wrote: > On Thu, Mar 10, 2022 at 06:01:48PM +, Andrew Cooper wrote: > > On 08/03/2022 14:52, Roger Pau Monne wrote: > > > On Tue, Mar 08, 2022 at 02:38:47PM +, Andrew Cooper wrote: > > >> On 02/03/2022 14:27, Roger Pau Monne wrote: >

Re: [PATCH 4/4] livepatch: differentiate between old and new build systems

2022-03-11 Thread Roger Pau Monné
On Thu, Mar 10, 2022 at 06:01:48PM +, Andrew Cooper wrote: > On 08/03/2022 14:52, Roger Pau Monne wrote: > > On Tue, Mar 08, 2022 at 02:38:47PM +, Andrew Cooper wrote: > >> On 02/03/2022 14:27, Roger Pau Monne wrote: > >>> diff --git a/livepatch-build b/livepatch-build > >>> index 38a92be..

Re: [PATCH 4/4] livepatch: differentiate between old and new build systems

2022-03-10 Thread Andrew Cooper
On 08/03/2022 14:52, Roger Pau Monne wrote: > On Tue, Mar 08, 2022 at 02:38:47PM +, Andrew Cooper wrote: >> On 02/03/2022 14:27, Roger Pau Monne wrote: >>> diff --git a/livepatch-build b/livepatch-build >>> index 38a92be..656cdac 100755 >>> --- a/livepatch-build >>> +++ b/livepatch-build >>> @@

Re: [PATCH 4/4] livepatch: differentiate between old and new build systems

2022-03-08 Thread Roger Pau Monné
On Tue, Mar 08, 2022 at 02:38:47PM +, Andrew Cooper wrote: > On 02/03/2022 14:27, Roger Pau Monne wrote: > > diff --git a/livepatch-build b/livepatch-build > > index 38a92be..656cdac 100755 > > --- a/livepatch-build > > +++ b/livepatch-build > > @@ -98,14 +98,20 @@ function build_special() > >

Re: [PATCH 4/4] livepatch: differentiate between old and new build systems

2022-03-08 Thread Andrew Cooper
On 02/03/2022 14:27, Roger Pau Monne wrote: > diff --git a/livepatch-build b/livepatch-build > index 38a92be..656cdac 100755 > --- a/livepatch-build > +++ b/livepatch-build > @@ -98,14 +98,20 @@ function build_special() > > # Build with special GCC flags > cd "${SRCDIR}/xen" || die > -

Re: [PATCH 4/4] livepatch: differentiate between old and new build systems

2022-03-08 Thread Ross Lagerwall
> From: Roger Pau Monne > Sent: Wednesday, March 2, 2022 2:27 PM > To: xen-devel@lists.xenproject.org > Cc: Ross Lagerwall ; konrad.w...@oracle.com > ; doe...@amazon.de ; jul...@xen.org > ; Andrew Cooper ; Roger Pau Monne > > Subject: [PATCH 4/4] livepatch: different

Re: [PATCH 4/4] livepatch: differentiate between old and new build systems

2022-03-02 Thread Doebel, Bjoern
On 02.03.22 15:27, Roger Pau Monne wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. Do not attempt to modify the build system if CFLAGS are not set in Rules.mk, and

Re: [PATCH 4/4] livepatch: differentiate between old and new build systems

2022-03-02 Thread Andrew Cooper
On 02/03/2022 15:41, Doebel, Bjoern wrote: > On 02.03.22 15:27, Roger Pau Monne wrote: >> CAUTION: This email originated from outside of the organization. Do >> not click links or open attachments unless you can confirm the sender >> and know the content is safe. >> >> >> >> Do not attempt to modif

Re: [PATCH 4/4] livepatch: differentiate between old and new build systems

2022-03-02 Thread Roger Pau Monné
On Wed, Mar 02, 2022 at 04:41:36PM +0100, Doebel, Bjoern wrote: > On 02.03.22 15:27, Roger Pau Monne wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know > > the content is safe. > > > >

Re: [PATCH 4/4] livepatch: differentiate between old and new build systems

2022-03-02 Thread Doebel, Bjoern
On 02.03.22 15:27, Roger Pau Monne wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. Do not attempt to modify the build system if CFLAGS are not set in Rules.mk, and i

[PATCH 4/4] livepatch: differentiate between old and new build systems

2022-03-02 Thread Roger Pau Monne
Do not attempt to modify the build system if CFLAGS are not set in Rules.mk, and instead rely on CONFIG_LIVEPATCH already setting -f{function,data}-sections. Signed-off-by: Roger Pau Monné --- This depends on getting the patch to add -f{function,data}-sections when using CONFIG_LIVEPATCH accepted