Re: [PATCH 4/9] x86emul: support CMPccXADD

2023-04-17 Thread Jan Beulich
On 06.04.2023 21:28, Andrew Cooper wrote: > On 04/04/2023 3:52 pm, Jan Beulich wrote: >> Unconditionally wire this through the ->rmw() hook. Since x86_emul_rmw() >> now wants to construct and invoke a stub, make stub_exn available to it >> via a new field in the emulator state structure. > > IMO,

Re: [PATCH 4/9] x86emul: support CMPccXADD

2023-04-06 Thread Andrew Cooper
On 04/04/2023 3:52 pm, Jan Beulich wrote: > Unconditionally wire this through the ->rmw() hook. Since x86_emul_rmw() > now wants to construct and invoke a stub, make stub_exn available to it > via a new field in the emulator state structure. IMO, patch 5 should be re-ordered with this, because it

[PATCH 4/9] x86emul: support CMPccXADD

2023-04-04 Thread Jan Beulich
Unconditionally wire this through the ->rmw() hook. Since x86_emul_rmw() now wants to construct and invoke a stub, make stub_exn available to it via a new field in the emulator state structure. Signed-off-by: Jan Beulich --- # SDE: -grr or -srf --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/li