Re: [PATCH 5/5] x86/p2m: split write_p2m_entry() hook

2020-11-18 Thread Roger Pau Monné
On Wed, Oct 28, 2020 at 10:24:53AM +0100, Jan Beulich wrote: > Fair parts of the present handlers are identical; in fact > nestedp2m_write_p2m_entry() lacks a call to p2m_entry_modify(). Move > common parts right into write_p2m_entry(), splitting the hooks into a > "pre" one (needed just by shadow

Re: [PATCH 5/5] x86/p2m: split write_p2m_entry() hook

2020-11-18 Thread Roger Pau Monné
On Fri, Nov 13, 2020 at 10:52:58AM +0100, Jan Beulich wrote: > On 12.11.2020 18:52, Tim Deegan wrote: > > At 15:04 +0100 on 12 Nov (1605193496), Jan Beulich wrote: > >> On 12.11.2020 14:07, Roger Pau Monné wrote: > >>> On Thu, Nov 12, 2020 at 01:29:33PM +0100, Jan Beulich wrote: > I agree

Re: [PATCH 5/5] x86/p2m: split write_p2m_entry() hook

2020-11-13 Thread Jan Beulich
On 12.11.2020 18:52, Tim Deegan wrote: > At 15:04 +0100 on 12 Nov (1605193496), Jan Beulich wrote: >> On 12.11.2020 14:07, Roger Pau Monné wrote: >>> On Thu, Nov 12, 2020 at 01:29:33PM +0100, Jan Beulich wrote: I agree with all this. If only it was merely about TLB flushes. In the shadow

Re: [PATCH 5/5] x86/p2m: split write_p2m_entry() hook

2020-11-12 Thread Tim Deegan
At 15:04 +0100 on 12 Nov (1605193496), Jan Beulich wrote: > On 12.11.2020 14:07, Roger Pau Monné wrote: > > On Thu, Nov 12, 2020 at 01:29:33PM +0100, Jan Beulich wrote: > >> I agree with all this. If only it was merely about TLB flushes. In > >> the shadow case, shadow_blow_all_tables() gets

Re: [PATCH 5/5] x86/p2m: split write_p2m_entry() hook

2020-11-12 Thread Jan Beulich
On 12.11.2020 14:07, Roger Pau Monné wrote: > On Thu, Nov 12, 2020 at 01:29:33PM +0100, Jan Beulich wrote: >> On 11.11.2020 13:17, Roger Pau Monné wrote: >>> On Tue, Nov 10, 2020 at 03:50:44PM +0100, Jan Beulich wrote: On 10.11.2020 14:59, Roger Pau Monné wrote: > On Wed, Oct 28, 2020 at

Re: [PATCH 5/5] x86/p2m: split write_p2m_entry() hook

2020-11-12 Thread Roger Pau Monné
On Thu, Nov 12, 2020 at 01:29:33PM +0100, Jan Beulich wrote: > On 11.11.2020 13:17, Roger Pau Monné wrote: > > On Tue, Nov 10, 2020 at 03:50:44PM +0100, Jan Beulich wrote: > >> On 10.11.2020 14:59, Roger Pau Monné wrote: > >>> On Wed, Oct 28, 2020 at 10:24:53AM +0100, Jan Beulich wrote: > ---

Re: [PATCH 5/5] x86/p2m: split write_p2m_entry() hook

2020-11-12 Thread Jan Beulich
On 11.11.2020 13:17, Roger Pau Monné wrote: > On Tue, Nov 10, 2020 at 03:50:44PM +0100, Jan Beulich wrote: >> On 10.11.2020 14:59, Roger Pau Monné wrote: >>> On Wed, Oct 28, 2020 at 10:24:53AM +0100, Jan Beulich wrote: --- a/xen/arch/x86/mm/p2m-pt.c +++ b/xen/arch/x86/mm/p2m-pt.c @@

Re: [PATCH 5/5] x86/p2m: split write_p2m_entry() hook

2020-11-11 Thread Roger Pau Monné
On Tue, Nov 10, 2020 at 03:50:44PM +0100, Jan Beulich wrote: > On 10.11.2020 14:59, Roger Pau Monné wrote: > > On Wed, Oct 28, 2020 at 10:24:53AM +0100, Jan Beulich wrote: > >> --- a/xen/arch/x86/mm/hap/nested_hap.c > >> +++ b/xen/arch/x86/mm/hap/nested_hap.c > >> @@ -71,24 +71,11 @@ > >> /*

Re: [PATCH 5/5] x86/p2m: split write_p2m_entry() hook

2020-11-10 Thread Jan Beulich
On 10.11.2020 14:59, Roger Pau Monné wrote: > On Wed, Oct 28, 2020 at 10:24:53AM +0100, Jan Beulich wrote: >> Fair parts of the present handlers are identical; in fact >> nestedp2m_write_p2m_entry() lacks a call to p2m_entry_modify(). Move >> common parts right into write_p2m_entry(), splitting

Re: [PATCH 5/5] x86/p2m: split write_p2m_entry() hook

2020-11-10 Thread Roger Pau Monné
On Wed, Oct 28, 2020 at 10:24:53AM +0100, Jan Beulich wrote: > Fair parts of the present handlers are identical; in fact > nestedp2m_write_p2m_entry() lacks a call to p2m_entry_modify(). Move > common parts right into write_p2m_entry(), splitting the hooks into a > "pre" one (needed just by shadow

Re: [PATCH 5/5] x86/p2m: split write_p2m_entry() hook

2020-10-29 Thread Tim Deegan
At 10:24 +0100 on 28 Oct (1603880693), Jan Beulich wrote: > Fair parts of the present handlers are identical; in fact > nestedp2m_write_p2m_entry() lacks a call to p2m_entry_modify(). Move > common parts right into write_p2m_entry(), splitting the hooks into a > "pre" one (needed just by shadow

[PATCH 5/5] x86/p2m: split write_p2m_entry() hook

2020-10-28 Thread Jan Beulich
Fair parts of the present handlers are identical; in fact nestedp2m_write_p2m_entry() lacks a call to p2m_entry_modify(). Move common parts right into write_p2m_entry(), splitting the hooks into a "pre" one (needed just by shadow code) and a "post" one. For the common parts moved I think that the