Re: [PATCH 8/9] gnttab: bail from GFN-storing loops early in case of error

2022-10-10 Thread Jan Beulich
On 07.10.2022 21:36, Andrew Cooper wrote: > On 26/08/2021 11:14, Jan Beulich wrote: >> --- a/xen/common/grant_table.c >> +++ b/xen/common/grant_table.c >> @@ -3289,17 +3292,15 @@ gnttab_get_status_frames(XEN_GUEST_HANDL >> "status frames, but has only %u\n", >> d

Re: [PATCH 8/9] gnttab: bail from GFN-storing loops early in case of error

2022-10-07 Thread Andrew Cooper
On 26/08/2021 11:14, Jan Beulich wrote: > The contents of the output arrays are undefined in both cases anyway > when the operation itself gets marked as failed. There's no value in > trying to continue after a guest memory access failure. > > Signed-off-by: Jan Beulich Not really Acked-by: Andre

[PATCH 8/9] gnttab: bail from GFN-storing loops early in case of error

2021-08-26 Thread Jan Beulich
The contents of the output arrays are undefined in both cases anyway when the operation itself gets marked as failed. There's no value in trying to continue after a guest memory access failure. Signed-off-by: Jan Beulich --- There's also a curious difference between the two sub-ops wrt the use of