Re: [PATCH V4 09/24] xen/ioreq: Make x86's IOREQ related dm-op handling common

2021-01-21 Thread Oleksandr
On 21.01.21 12:27, Jan Beulich wrote: Hi Jan On 21.01.2021 11:23, Oleksandr wrote: I would like to clarify regarding do_dm_op() which is identical for both arches and could *probably* be moved to the common code (we can return common dm.c back to put it there) and make dm_op() global. Would

Re: [PATCH V4 09/24] xen/ioreq: Make x86's IOREQ related dm-op handling common

2021-01-21 Thread Jan Beulich
On 21.01.2021 11:23, Oleksandr wrote: > I would like to clarify regarding do_dm_op() which is identical for both > arches and could *probably* be moved to the common code (we can return > common dm.c back to put it there) and make dm_op() global. > Would you/Paul be happy with that change? Or

Re: [PATCH V4 09/24] xen/ioreq: Make x86's IOREQ related dm-op handling common

2021-01-21 Thread Oleksandr
On 20.01.21 18:21, Jan Beulich wrote: Hi Jan On 12.01.2021 22:52, Oleksandr Tyshchenko wrote: From: Julien Grall As a lot of x86 code can be re-used on Arm later on, this patch moves the IOREQ related dm-op handling to the common code. The idea is to have the top level dm-op handling

Re: [PATCH V4 09/24] xen/ioreq: Make x86's IOREQ related dm-op handling common

2021-01-20 Thread Jan Beulich
On 12.01.2021 22:52, Oleksandr Tyshchenko wrote: > From: Julien Grall > > As a lot of x86 code can be re-used on Arm later on, this patch > moves the IOREQ related dm-op handling to the common code. > > The idea is to have the top level dm-op handling arch-specific > and call into

RE: [PATCH V4 09/24] xen/ioreq: Make x86's IOREQ related dm-op handling common

2021-01-18 Thread Paul Durrant
> -Original Message- [snip] > >> diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c > >> index a319c88..72b5da0 100644 > >> --- a/xen/common/ioreq.c > >> +++ b/xen/common/ioreq.c > >> @@ -591,8 +591,8 @@ static void hvm_ioreq_server_deinit(struct > >> ioreq_server *s) > >>

Re: [PATCH V4 09/24] xen/ioreq: Make x86's IOREQ related dm-op handling common

2021-01-18 Thread Oleksandr
Jackson ; Julien Grall ; Stefano Stabellini ; Paul Durrant ; Daniel De Graaf ; Oleksandr Tyshchenko Subject: [PATCH V4 09/24] xen/ioreq: Make x86's IOREQ related dm-op handling common From: Julien Grall As a lot of x86 code can be re-used on Arm later on, this patch moves the IOREQ related dm

RE: [PATCH V4 09/24] xen/ioreq: Make x86's IOREQ related dm-op handling common

2021-01-18 Thread Paul Durrant
; Julien > Grall ; > Stefano Stabellini ; Paul Durrant ; > Daniel De Graaf > ; Oleksandr Tyshchenko > Subject: [PATCH V4 09/24] xen/ioreq: Make x86's IOREQ related dm-op handling > common > > From: Julien Grall > > As a lot of x86 code can be re-used on Arm l

[PATCH V4 09/24] xen/ioreq: Make x86's IOREQ related dm-op handling common

2021-01-12 Thread Oleksandr Tyshchenko
From: Julien Grall As a lot of x86 code can be re-used on Arm later on, this patch moves the IOREQ related dm-op handling to the common code. The idea is to have the top level dm-op handling arch-specific and call into ioreq_server_dm_op() for otherwise unhandled ops. Pros: - More natural than