Re: [PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction

2021-03-04 Thread Julien Grall
Hi Juergen, On 04/03/2021 09:48, Jürgen Groß wrote: On 04.03.21 10:39, Julien Grall wrote: On 04/03/2021 09:00, Jürgen Groß wrote: On 03.03.21 18:05, Julien Grall wrote: From: Julien Grall As XenStored is single-threaded, conn->ta_start_time will always be smaller than now. As we

Re: [PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction

2021-03-04 Thread Jürgen Groß
On 04.03.21 10:39, Julien Grall wrote: On 04/03/2021 09:00, Jürgen Groß wrote: On 03.03.21 18:05, Julien Grall wrote: From: Julien Grall As XenStored is single-threaded, conn->ta_start_time will always be smaller than now. As we substract the latter from the former, it means a transaction

Re: [PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction

2021-03-04 Thread Julien Grall
On 04/03/2021 09:00, Jürgen Groß wrote: On 03.03.21 18:05, Julien Grall wrote: From: Julien Grall As XenStored is single-threaded, conn->ta_start_time will always be smaller than now. As we substract the latter from the former, it means a transaction will never be considered long running.

Re: [PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction

2021-03-04 Thread Jürgen Groß
On 03.03.21 18:05, Julien Grall wrote: From: Julien Grall As XenStored is single-threaded, conn->ta_start_time will always be smaller than now. As we substract the latter from the former, it means a transaction will never be considered long running. Invert the two operands of the substraction

Re: [PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction

2021-03-03 Thread Ian Jackson
Julien Grall writes ("Re: [PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction"): > On 03/03/2021 17:41, Ian Jackson wrote: > > AFAICT this only affects live updated which is not security-supported > > in 4.15 and which won't block our te

Re: [PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction

2021-03-03 Thread Julien Grall
Hi Ian, On 03/03/2021 17:41, Ian Jackson wrote: Julien Grall writes ("[PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction"): From: Julien Grall As XenStored is single-threaded, conn->ta_start_time will always be smaller than now. As we substract th

Re: [PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction

2021-03-03 Thread Ian Jackson
Julien Grall writes ("[PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction"): > From: Julien Grall > > As XenStored is single-threaded, conn->ta_start_time will always be > smaller than now. As we substract the latter from the former, it means &

[PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction

2021-03-03 Thread Julien Grall
From: Julien Grall As XenStored is single-threaded, conn->ta_start_time will always be smaller than now. As we substract the latter from the former, it means a transaction will never be considered long running. Invert the two operands of the substraction in both lu_reject_reason() and